Conversation
3 tasks
3 tasks
zJaaal
requested review from
KevinDavilaDotCMS,
adrianjm-dotCMS,
dario-daza,
fmontes,
hmoreras,
nicobytes,
oidacra and
rjvelazco
and removed request for
hmoreras
github-actions
Bot
added
the
Area : Frontend
fmontes
approved these changes
Mar 9, 2026
dario-daza
approved these changes
Mar 9, 2026
zJaaal
deleted the
34889-defect-ux-fixes-after-modernization-upgrade-in-content-drive
branch
spbolton
pushed a commit
that referenced
this pull request
Mar 24, 2026
…e filter #34889 (#34918) ### Proposed Changes * Fix toolbar height constraint: changed `[style.height]` to `[style.min-height]` on the host element so the Content Drive filter table is not cut off on smaller screens or when DevTools is open * Add `autofocusFilter="true"` to the content type `p-select` component so the filter input correctly focuses and displays typed characters beyond the first letter ### Checklist - [ ] Tests - [ ] Translations - [x] Security Implications Contemplated (no security impact — UI/styling fixes only) ### Additional Info Fixes #34889 — Multiple UX regressions introduced after the Content Drive modernization upgrade. The `height` binding was preventing the toolbar from expanding on smaller viewports, causing the filter table to be clipped. The missing `autofocusFilter` attribute on the PrimeNG Select component caused the filter input to lose focus after the first keystroke, making multi-character filtering impossible. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
[style.height]to[style.min-height]on the host element so the Content Drive filter table is not cut off on smaller screens or when DevTools is openautofocusFilter="true"to the content typep-selectcomponent so the filter input correctly focuses and displays typed characters beyond the first letterChecklist
Additional Info
Fixes #34889 — Multiple UX regressions introduced after the Content Drive modernization upgrade.
The
heightbinding was preventing the toolbar from expanding on smaller viewports, causing the filter table to be clipped. The missingautofocusFilterattribute on the PrimeNG Select component caused the filter input to lose focus after the first keystroke, making multi-character filtering impossible.🤖 Generated with Claude Code
This PR fixes: #34889