Skip to content

fix(angular-ssr): remove invalid "public" property from vercel.json#36212

Merged
fmontes merged 1 commit into
mainfrom
fmontes/fix-angular-ssr-example
Jun 17, 2026
Merged

fix(angular-ssr): remove invalid "public" property from vercel.json#36212
fmontes merged 1 commit into
mainfrom
fmontes/fix-angular-ssr-example

Conversation

@fmontes

@fmontes fmontes commented Jun 17, 2026

Copy link
Copy Markdown
Member

What

Removes the invalid "public": true property from examples/angular-ssr/vercel.json.

Why

Vercel's current vercel.json schema no longer accepts a top-level public property. Deployments of the angular-ssr example fail at build time with:

The vercel.json schema validation failed with the following message: should NOT have additional property public

Fix

Dropped the single offending line. The remaining rewrites and functions config is unchanged and schema-valid.

Fixes #36211

🤖 Generated with Claude Code

…36211)

Vercel's current schema rejects the top-level `public` property, causing
the angular-ssr example deployment to fail schema validation at build time.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude

claude Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Claude finished @fmontes's task in 34s —— View job


Rollback Safety Analysis

  • Read rollback-unsafe categories reference
  • Get full PR diff
  • Analyze diff against all unsafe categories
  • Apply appropriate label

Result: ✅ Safe to Roll Back

The only change in this PR is removing one line from examples/angular-ssr/vercel.json:

-  "public": true,

This is a deployment config file for an example project. It touches no database migrations, Elasticsearch mappings, data models, REST/GraphQL API contracts, OSGi interfaces, VTL viewtools, or any other category in the rollback-unsafe reference. The label AI: Safe To Rollback has been applied.

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

🤖 Bedrock Review — deepseek.v3.2

[🟡 Medium] examples/angular-ssr/vercel.json:3 — Removing "public": true may affect Vercel deployment behavior, potentially making the project private or changing asset accessibility. This could break deployment expectations if the project relies on public hosting.


Run: #27712780303 · tokens: in: 477 · out: 60 · total: 537

@fmontes fmontes added this pull request to the merge queue Jun 17, 2026
Merged via the queue into main with commit ff3a36e Jun 17, 2026
37 checks passed
@fmontes fmontes deleted the fmontes/fix-angular-ssr-example branch June 17, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Fix Vercel build failure in angular-ssr example: invalid "public" property in vercel.json

2 participants