Skip to content

36387 complete nx convert to inferred infer targets across remaining plugins - #36444

Merged
nicobytes merged 5 commits into
mainfrom
36387-complete-nx-convert-to-inferred-infer-targets-across-remaining-plugins
Jul 8, 2026
Merged

36387 complete nx convert to inferred infer targets across remaining plugins#36444
nicobytes merged 5 commits into
mainfrom
36387-complete-nx-convert-to-inferred-infer-targets-across-remaining-plugins

Conversation

@nicobytes

@nicobytes nicobytes commented Jul 7, 2026

Copy link
Copy Markdown
Member

This pull request migrates several Nx library projects to use "inferred" build configurations, which separates build options from project.json files into dedicated config files (such as rollup.config.cjs and vite.config.ts). This change improves maintainability and aligns with Nx's latest best practices. Additionally, it updates output paths, cache settings, and build dependencies for better reproducibility and caching. Some scripts and ESLint rules are also adjusted to accommodate the new structure.

Migration to inferred build configurations:

  • Added new rollup.config.cjs files for sdk/client, sdk/ai, sdk/experiments, sdk/react, sdk/types, and sdk/uve libraries, moving build options out of project.json and into these config files using withNx. [1] [2] [3] [4] [5] [6]
  • Updated vite.config.ts and vite.standalone.config.mts files for edit-content-bridge, sdk/analytics, and sdk/experiments to pull build options from new config objects, reflecting the migration. [1] [2] [3] [4]

Project configuration updates:

  • Removed build options from project.json files in affected libraries and replaced them with references to the new config files, as well as updating output paths, cache settings, and build dependencies for improved build reproducibility and caching. [1] [2] [3] [4] [5] [6] [7] [8]

Build and linting improvements:

  • Updated the ESLint config for sdk/types to ignore the new rollup.config.cjs file, preventing false positives for missing runtime dependencies.
  • Removed the now-unnecessary build script from sdk/client/package.json.

These changes modernize the build setup, improve maintainability, and align the codebase with Nx's recommended practices.

This PR fixes: #36387

Screenshot 2026-07-07 at 11 30 51 AM Screenshot 2026-07-07 at 11 31 01 AM Screenshot 2026-07-07 at 11 31 12 AM

This PR fixes: #36387

nicobytes added 3 commits July 6, 2026 16:28
Convert several SDK and bridge libraries from explicit `project.json` build executors to Nx inferred Vite/Rollup targets. This adds per-library `rollup.config.cjs` files, updates Vite configs and `nx.json` plugin registration, preserves build outputs/dependencies/caching, and adjusts related cleanup like the React migrated Rollup config, ESLint dependency-check ignores, and the redundant client build script.
…oss-remaining-plugins' of github.com:dotCMS/core into 36387-complete-nx-convert-to-inferred-infer-targets-across-remaining-plugins
@nicobytes
nicobytes requested a review from a team as a code owner July 7, 2026 01:50
@nicobytes nicobytes linked an issue Jul 7, 2026 that may be closed by this pull request
4 tasks
@github-actions github-actions Bot added Area : CI/CD PR changes GitHub Actions/workflows Area : Frontend PR changes Angular/TypeScript frontend code Area : SDK PR changes SDK libraries labels Jul 7, 2026
@claude

claude Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Claude finished @nicobytes's task in 51s —— View job


Rollback-Safety Analysis

  • Read docs/core/ROLLBACK_UNSAFE_CATEGORIES.md
  • Diff 8d3af443...00b20e34 against every unsafe category
  • Post verdict

Result: No rollback-unsafe categories matched.

This PR is exclusively frontend build tooling / Storybook removal:

  • Deletes Storybook config, stories (*.stories.ts/.js), and core-web/documentation.json
  • Migrates several core-web/libs/sdk/* and other Nx projects from executor-based project.json targets to inferred targets (rollup.config.cjs, vite.config.ts additions)
  • Updates nx.json, package.json, pnpm-lock.yaml, .prettierignore, eslint.config.mjs
  • Trims the publish_docs.yml workflow's Storybook build/deploy steps

There are no Java files, runonce migration tasks, Elasticsearch mapping changes, contentlet_as_json model changes, SQL DDL, REST/GraphQL contract changes, VTL viewtool changes, or OSGi interface changes anywhere in this diff. Nothing here affects server-side data, storage, or API contracts — N-1 is unaffected by rolling back.

Labeling as safe to rollback.

@nicobytes

Copy link
Copy Markdown
Member Author

@copilot resolve the merge conflicts in this pull request

Copilot AI commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflict in core-web/nx.json. The conflict arose from new targetDefaults entries (@nx/jest:jest, @nx/eslint:lint, @nx/rollup:rollup, @nx/vite:build) added in main that weren't present in this branch. These have been incorporated in commit 7193ec3.

@github-actions github-actions Bot removed AI: Safe To Rollback Area : CI/CD PR changes GitHub Actions/workflows labels Jul 7, 2026
@mergify

mergify Bot commented Jul 7, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@nicobytes
nicobytes added this pull request to the merge queue Jul 8, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 8, 2026
@nicobytes
nicobytes added this pull request to the merge queue Jul 8, 2026
Merged via the queue into main with commit 442c7aa Jul 8, 2026
37 of 38 checks passed
@nicobytes
nicobytes deleted the 36387-complete-nx-convert-to-inferred-infer-targets-across-remaining-plugins branch July 8, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area : Frontend PR changes Angular/TypeScript frontend code Area : SDK PR changes SDK libraries

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Complete Nx convert-to-inferred (infer-targets) across remaining plugins

3 participants