fix(edit-content): show exact date/time in History cards, remove relative time and tooltip - #36450
Merged
Merged
Conversation
The History side panel's Version cards always showed relative time (now, two days ago) with the exact date/time only revealed via a hover tooltip. Per #36374, cards now always display the exact date/time (e.g. May 16, 2026 - 1:10 PM) so users don't have to hover to know when a version was created, including for the current/working version which previously showed a static "Current" label instead of any date. The tooltip is kept but no longer duplicates the date since it's now always visible; title/language/variant info in it is unchanged. Applied the same fix to the sibling Push Publish cards in the same panel for UI consistency, since they had the identical relative-time + tooltip pattern (not explicitly part of #36374, called out separately for reviewers). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
Claude finished @jcastro-dotcms's task in 3m 31s —— View job Code ReviewReviewed the full diff (
New IssuesNo issues found. Notes
One non-blocking product/UX consideration (already flagged by the author in the PR description, not a code defect): removing the tooltips drops LGTM. ✅ |
oidacra
reviewed
Jul 8, 2026
Product decided to drop the date/time hover tooltip entirely rather than keep it for the remaining title/language/variant (Versions) or environment/bundle (Push Publish) info, now that #36374 makes cards always show the exact date/time up front. Note: this removes the only place some fields were visible in the UI - Versions cards no longer show content title or language flag anywhere (the experiment variant is still indicated via its tag chip, just not the variant name/value). - Push Publish cards no longer show the environment name or full bundle ID as text (the bundle ID is still copyable via the existing copy button). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
adrianjm-dotCMS
approved these changes
Jul 8, 2026
The third it.each case (13:10 -> 1:10 PM) exactly duplicated the two it() tests directly above it, adding no new coverage. Swapped for 23:59 -> 11:59 PM to actually exercise a distinct boundary. Addresses PR review feedback from @oidacra. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #36374.
The History side panel's Version cards always showed relative time (
now,two days ago), with the exact date/time only revealed via a hover tooltip — and the current/working version showed a staticCurrentlabel instead of any date at all. Per the ticket, cards now always display the exact date/time (e.g.May 16, 2026 - 1:10 PM), for every version including the current one.dot-history-timeline-item: time display now always renders{{ modDate | date: 'MMM d, yyyy - h:mm a' }}— theworking→"Current"special case and thedotRelativeDatepipe usage are removed.inject(DatePipe)field/providersentry, and the now-unusedDotRelativeDatePipeimport.Scope extension (flagging for reviewers): the sibling Push Publish cards, in the same History panel (
dot-pushpublish-timeline-item), had the identical relative-time + tooltip pattern. This wasn't explicitly called out in #36374, but we fixed it too for UI consistency within the same panel — same treatment: exact date/time always shown.Update: the hover tooltip was initially kept (with just its redundant date line dropped) but Product decided afterward to remove the tooltip entirely on both card types. Flagging for reviewers: this means some fields that only ever lived in the tooltip are no longer shown anywhere in the UI:
titleandlanguageFlagare no longer displayed (the experiment variant is still indicated via the existing "Variant" tag chip, just not its actual value).environmentname and the fullbundleIdtext are no longer displayed (the bundle ID remains copyable via the existing copy button, just not shown as text).Test plan
dot-history-timeline-item: exact-format assertions for both working and non-working versions, AM/PM boundary cases (12:00 AM,12:00 PM,1:10 PM), a guard that no version ever renders "now"/"ago"/"current", and a guard that no tooltip is rendereddot-pushpublish-timeline-itemasserting exact-format output with no relative string and no tooltippnpm nx test edit-content— all 40 relevant tests passingpnpm nx lint edit-content— clean (only pre-existing, unrelated warnings)dotcms/dotcms-test:1.0.0-SNAPSHOT): History → Versions panel shows exact date/time for all versions including the currently published one, no tooltip on hover🤖 Generated with Claude Code
This PR fixes: #36374