Conversation
…sdk action - Added a check to skip processing for SDKs that do not contain a package.json file, preventing unnecessary errors during deployment. - Updated vite.config.mts for both analytics and vue SDKs to include package.json in the static copy targets, ensuring it is copied to the distribution directory alongside markdown files. This change enhances the deployment process by ensuring only valid SDKs are processed and necessary files are included in the build output.
|
Claude finished @nicobytes's task in 5m 53s —— View job Code Review
SummaryThe core fix is sound. Both New Issues
Not blocking — the merged behavior is correct for the current build graph. Flagging only the description/code mismatch. |
…t-sdk action - Eliminated the check for the presence of package.json in the deploy-javascript-sdk action, streamlining the deployment process for SDKs. - This change allows the action to proceed without skipping SDKs based on the absence of package.json, enhancing flexibility in deployment. This update simplifies the deployment logic and focuses on processing SDKs without unnecessary checks.
|
Tick the box to add this pull request to the merge queue (same as
|
Summary
package.json(and README) copy intodistfor@dotcms/analyticsand@dotcms/vueviaviteStaticCopy, replacing a hidden side effect of the removednxViteTsPaths()plugin.distdirectories that have nopackage.json(e.g.analytics-standalone), so the publish loop does not fail withjq: Could not open file package.json.Context
Trunk SDK
@nextpublish failed on run 29416418823 after #36575 replacednxViteTsPaths()withvite-tsconfig-paths. The Nx plugin copiedpackage.jsoninto the ViteoutDironwriteBundle; the replacement does not. Publish then crashed while processing@dotcms/analyticsafter partially publishingai,angular, andtypesas1.7.1-next.2363.Test plan
pnpm exec nx build sdk-analytics --configuration=production—dist/libs/sdk/analytics/package.jsonpresentpnpm exec nx build sdk-vue --configuration=production—dist/libs/sdk/vue/package.jsonpresent@nextset (newrun_number; do not re-run 2363)This PR fixes: #36540
This PR fixes: #36540