fix(block-editor): preserve hard breaks on load for restricted fields

[oidacra]

Summary

The legacy Block Editor silently stripped hardBreak (Shift+Enter) nodes when re-opening content for editing on fields configured with allowed-block restrictions. setEditorJSONContent runs loaded JSON through removeInvalidNodes → purifyNodeTree, which drops any node whose type isn't in the allowed map. hardBreak was never in the map, so every line break was lost on load — causing silent formatting/data loss on the next save.

This adds hardBreak to the always-allowed basicNodes map and fixes the latent paragrah → paragraph typo in the same map (the paragraph basic-node fallback was previously dead code).

Only affects fields with allowedBlocks.length > 1; unrestricted fields never entered the filtering path. The new Block Editor (@dotcms/new-block-editor) does not filter on load and was never affected.

Closes #35985

Acceptance Criteria

• Hard breaks preserved when re-opening content, including on restricted-block fields
• hardBreak treated as an always-allowed basic node so purifyNodeTree/removeInvalidNodes never strips it
• paragrah → paragraph typo fixed
• Saving previously-saved content no longer drops line breaks (same load path)
• Regression coverage: hardBreak survives removeInvalidNodes on a restricted editor

Test Plan

• pnpm nx test block-editor --testPathPatterns=parser.utils — 8 tests pass (parser.utils.ts at 97% coverage)
• Verified manually in the editor: restricted-block field with a multi-line paragraph (Shift+Enter) now retains its line breaks after save + re-open

Changed Files

• core-web/libs/block-editor/src/lib/shared/utils/parser.utils.ts
• core-web/libs/block-editor/src/lib/shared/utils/parser.utils.spec.ts (new)

This PR fixes: #35985

[alwaysmeticulous]

Meticulous was unable to execute a test run for this PR because the most recent commit is associated with multiple PRs. To execute a test run, please try pushing up a new commit that is only associated with this PR.

_{Last updated for commit 5503f34. This comment will update as new commits are pushed.}

[claude]

Claude finished @oidacra's task in 3m 7s —— View job

---

Claude finished @oidacra's task in 1m 3s —— View job

---

Code Review

• Read changed files (parser.utils.ts, parser.utils.spec.ts)
• Verify the fix against the load/filter path (removeInvalidNodes → purifyNodeTree)
• Check for regressions and shared-state issues
• Review test coverage

---

I reviewed the diff. This is a correct, well-scoped fix.

New Issues

No issues found.

Notes

• parser.utils.ts:41-46 — Adding hardBreak to basicNodes is the right layer. getBlockMap seeds its reduce with basicNodes, so any allowed-block config now always carries paragraph/text/doc/hardBreak. The reduce spreads ({ ...blocks, ... }) rather than mutating, so the shared basicNodes object is never corrupted across calls — no shared-state hazard from making it a named const.
• parser.utils.ts:42 — The paragrah → paragraph typo fix is real and consequential: the previous key never matched NodeTypes.PARAGRAPH ('paragraph'), so the paragraph basic-node fallback was dead code. Using the NodeTypes enum here removes the whole class of typo. The new test at parser.utils.spec.ts:137 (paragraph survives via fallback when not in allowedBlocks) locks this in.
• Scope — Correctly limited to the restricted-field load path. removeInvalidNodes is only invoked when allowedBlocks.length > 1 (dot-block-editor.component.ts:710), so unrestricted fields are untouched, and the new block editor doesn't filter on load.
• Tests — Coverage is solid: getBlockMap basics, purifyNodeTree nesting/heading-level composite keys, and the removeInvalidNodes regression for Block Editor: strips hard breaks (Shift+Enter) when re-opening content for edit #35985 (both doc-node and bare-array inputs), plus the negative case that non-basic/non-allowed nodes are still stripped.

Optional (non-blocking): the recursion in purifyNodeTree and the isHeading helper are still untyped (node/blocksMap are implicit any). Not introduced by this PR, but if you're already touching this file, adding JSONContent/BlockMap annotations would be a cheap progressive-enhancement win.

LGTM. ✅
· issue-35985-block-editor-strips-hard-breaks-shift-enter-when

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request