DataTargetWrapper: expose ICLRSymbolProvider.TryGetFieldOffset via CCW#5916
Merged
max-charlamb merged 1 commit intoJul 7, 2026
Conversation
PR dotnet#5899 added HostSymbolProvider.TryGetFieldOffset as the managed implementation for the third ICLRSymbolProvider method, but the CCW built by DataTargetWrapper still only advertises TryGetSymbolName and TryGetSymbolAddress. Any managed consumer that QIs for the interface and calls the third slot dereferences an unallocated vtable entry, which manifests as a native access violation instead of E_NOTIMPL. Register the missing method on the vtable and forward it to IClrSymbolProvider.TryGetFieldOffset, mirroring the shape of the existing TryGetSymbolAddress forwarder. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes the ICLRSymbolProvider COM Callable Wrapper (CCW) exposed by SOS.Hosting.DataTargetWrapper so its vtable matches the managed interface shape after PR #5899 added the third method (TryGetFieldOffset). This prevents native consumers from dereferencing a missing vtable slot when calling the third method via the ICLRSymbolProvider IID.
Changes:
- Registers
TryGetFieldOffsetas the third method in theICLRSymbolProvidervtable forDataTargetWrapper. - Implements the
TryGetFieldOffsetCCW forwarder and delegates it toIClrSymbolProvider.TryGetFieldOffset, with consistent HRESULT behavior (E_INVALIDARG,E_NOTIMPL,E_FAIL,S_OK). - Adds the corresponding unmanaged delegate signature with correct string marshalling (
LPWStr).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
steveisok
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #5899 added
HostSymbolProvider.TryGetFieldOffsetas the managed implementation of the thirdICLRSymbolProvidermethod, but the corresponding CCW built byDataTargetWrapperwas not updated. The interface's vtable still only advertises two methods (TryGetSymbolName,TryGetSymbolAddress).