Fixes #20150 by updating global-json.md to have cleaner info on match…#21290
Merged
tdykstra merged 5 commits intodotnet:masterfrom Nov 2, 2020
eriawan:patch-1
Merged
Fixes #20150 by updating global-json.md to have cleaner info on match…#21290tdykstra merged 5 commits intodotnet:masterfrom eriawan:patch-1
tdykstra merged 5 commits intodotnet:masterfrom
eriawan:patch-1
Conversation
…ing rules Fixes #20150 using suggestions from @benmccallum to have cleaner info on matching rules cc @tdykstra
Youssef1313
reviewed
Oct 31, 2020
Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
tdykstra
reviewed
Nov 2, 2020
Contributor
tdykstra
left a comment
tdykstra
left a comment
There was a problem hiding this comment.
Thanks, looks good -- I made a couple of minor suggestions.
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Member
Author
|
Thanks @tdykstra 👍 PR updated. |
tdykstra
reviewed
Nov 2, 2020
Co-authored-by: Tom Dykstra <tdykstra@microsoft.com>
Member
Author
|
@tdykstra |
Member
Author
|
@tdykstra |
Contributor
|
No, I'll merge now. |
tdykstra
approved these changes
Nov 2, 2020
BillWagner
added
dotnet-core/prod
cli/subsvc
and removed
📚 Area - .NET Core Guide
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes are based on suggestions on #20150 (comment)
Fixes #20150
cc @tdykstra