Merge net6-rc1 to main #7182
Merged
Merge net6-rc1 to main #7182
+23,236
−17,964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=248605&view=results source_repo.branch:net6-rc1 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
* Update InteropServices doc * Docs for MemoryMarshal and PosixSignalContext. * Doc update for CollectionsMarshal * Update docs for Objective-C classes
* Port triple-slash comments to docs for Microsoft.Extensions.Http * Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
* Add WebSocket and HttpHeadersNonValidated missing APIs * Update xml/System.Net.Http.Headers/HttpHeadersNonValidated.xml Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Port System.Net triple slash to docs * Address suggestions by gewarren Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
* Port System.Text.Json triple slash to docs * fix warnings * Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Port System.Diagnostics triple slash to docs * Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Update symlink documentation * Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Port System triple slash to docs * Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> * String suggestions Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
…e slash to docs (#7102) * Port System.Runtime.Versioning.RequiresPreviewFeaturesAttribute triple slash to docs * suggestion by pgovind * add link * Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Port System.Reflection triple slash to docs * Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Co-authored-by: Buyaa Namnan <buyankhishig.namnan@microsoft.com> Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Co-authored-by: Buyaa Namnan <buyankhishig.namnan@microsoft.com>
…y triple slash to docs (#7097) Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
* Port System.Security.Cryptography.Xml triple slash to docs * Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> * Update xml/System.Security.Cryptography.Xml/CryptoSignedXmlRecursionException.xml Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
* Add docs for missing members in System.CodeDom * Add missing return statement * Apply suggestions from code review Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com> Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
* Port System.Security.Cryptography triple slash to docs * Fix -or- spacing * Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
…cs (#7095) Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
* Ported docs from dotnet/runtime#57855 * Update xml/System.Net.Http/HeaderEncodingSelector`1.xml Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
…uestMessage.Options
* Correct missing devdoc. * Apply suggestions from code review Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
* Port IntPtr and MemoryExtensions triple slash to docs * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com> Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
missing doc for HttpRequestOptions
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=252527&view=results source_repo.branch:net6-rc1 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
gewarren
requested review from
a team,
JRahnama,
RussKie,
ViktorHofer,
jozkee,
karinazhou,
kouvel,
krwq,
layomia,
maryamariyan,
mconnew,
merriemcgaw,
michaelgsharp,
pgovind,
safern,
steveharter,
tannergooding and
tarekgh
as code owners
ghost
added
the
area-Meta
Comment on lines
164
to
165
| We need to respect the semicolon that he put in the value, and need to treat | ||
| this exactly as if he had done: |
There was a problem hiding this comment.
I remember seeing a PR asking to revert this change back to they.
carlossanlop
approved these changes
Sep 14, 2021
This comment has been minimized.
This comment has been minimized.
carlossanlop
approved these changes
Sep 14, 2021
@gewarren This came from one of the WPF net6-rc1 PRs I approved. They used DocsPortingTool to port some docs, and the encoding of the files was changed unexpectedly. This shouldn't happen too often. It seems to be an edge case which I need to investigate, but as you correctly stated, there was no lost info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.