-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Clarify that the array passed to ByteArrayContent should not be modified. #8484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify that the array passed to ByteArrayContent should not be modified. #8484
Conversation
|
Tagging subscribers to this area: @dotnet/ncl |
|
Learn Build status updates of commit c8b65cf: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
xml/System.Net.Http/ByteArrayContent.xml
For more details, please refer to the build report. If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
|
Learn Build status updates of commit 2183db0: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
| <format type="text/markdown"><![CDATA[ | ||
| ## Remarks | ||
| The <xref:System.Net.Http.ByteArrayContent> class does not internally copy the provided byte array but keeps a reference to it instead. Callers should not modify the data in the array until the content is sent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
until the content is sent
"until after the content is sent"
Fixes #794