Skip to content

Conversation

@rzikm
Copy link
Member

@rzikm rzikm commented Oct 10, 2022

Fixes #794

@rzikm rzikm requested a review from a team as a code owner October 10, 2022 08:36
@rzikm rzikm enabled auto-merge (squash) October 10, 2022 08:36
@ghost ghost assigned rzikm Oct 10, 2022
@ghost ghost added the area-System.Net label Oct 10, 2022
@ghost
Copy link

ghost commented Oct 10, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #794

Author: rzikm
Assignees: rzikm
Labels:

area-System.Net

Milestone: -

@opbld32
Copy link

opbld32 commented Oct 10, 2022

Learn Build status updates of commit c8b65cf:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details
xml/System.Net.Http/ByteArrayContent.xml ❌Error Details

  • Line 0, Column 0: [Error: ECMA2Yaml_File_LoadFailed] Failed to load 1 files, aborting...

xml/System.Net.Http/ByteArrayContent.xml

  • Line 0, Column 0: [Error: ECMA2Yaml_InternalError]
Intenal Several Error: System.Xml.XmlException: '<' is an unexpected token. The expected token is '>'. Line 25, position 3.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.Throw(String res, String[] args)
   at System.Xml.XmlTextReaderImpl.ThrowUnexpectedToken(String expectedToken1, String expectedToken2)
   at System.Xml.XmlTextReaderImpl.ThrowUnexpectedToken(Int32 pos, String expectedToken1, String expectedToken2)
   at System.Xml.XmlTextReaderImpl.ParseEndElement()
   at System.Xml.XmlTextReaderImpl.ParseElementContent()
   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r)
   at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)
   at System.Xml.Linq.XDocument.Parse(String text, LoadOptions options)
   at ECMA2Yaml.ECMALoader.LoadType(FileItem typeFile)
   at ECMA2Yaml.ECMALoader.LoadTypes(String basePath, Namespace ns)

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
@opbld32
Copy link

opbld32 commented Oct 10, 2022

Learn Build status updates of commit 2183db0:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/ByteArrayContent.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@rzikm rzikm merged commit b84d718 into dotnet:main Oct 10, 2022
<format type="text/markdown"><![CDATA[
## Remarks
The <xref:System.Net.Http.ByteArrayContent> class does not internally copy the provided byte array but keeps a reference to it instead. Callers should not modify the data in the array until the content is sent.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

until the content is sent

"until after the content is sent"

rzikm added a commit to rzikm/dotnet-api-docs that referenced this pull request Oct 10, 2022
rzikm added a commit to rzikm/dotnet-api-docs that referenced this pull request Nov 7, 2022
rzikm added a commit that referenced this pull request Nov 7, 2022
* Feedback from #8467

* Feedback from #8482

* Feedback from #8484

* Feedback from #8460

* More fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarifying ByteArrayContent's behaviour

4 participants