Skip to content

Conversation

@rzikm
Copy link
Member

@rzikm rzikm commented Oct 10, 2022

This PR fixes issues from comments made after the respective PRs have been merged.

cc: @stephentoub.

@rzikm rzikm requested review from a team as code owners October 10, 2022 15:05
@rzikm rzikm enabled auto-merge (squash) October 10, 2022 15:06
@ghost ghost assigned rzikm Oct 10, 2022
@ghost ghost added the area-System.Net label Oct 10, 2022
@ghost
Copy link

ghost commented Oct 10, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR fixes issues from comments made after the respective PRs have been merged.

cc: @stephentoub.

Author: rzikm
Assignees: rzikm
Labels:

area-System.Net

Milestone: -

@opbld34
Copy link

opbld34 commented Oct 10, 2022

Learn Build status updates of commit b9c36d4:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Net.Sockets/TcpClient/Overview/tcpclient.cs ✅Succeeded View
snippets/csharp/System.Net.Sockets/TcpListener/Overview/tcpserver.cs ✅Succeeded View
snippets/csharp/System.Net/HttpVersion/Overview/httpversion_version10.cs ✅Succeeded View
snippets/csharp/System.Net/WebClient/Overview/useragent.cs ✅Succeeded View
snippets/visualbasic/VS_Snippets_Remoting/NCLWebClientUserAgent/VB/useragent.vb ✅Succeeded View
xml/System.Net.Http/ByteArrayContent.xml ✅Succeeded View
xml/System.Net.NetworkInformation/Ping.xml ✅Succeeded View
xml/System.Net/WebProxy.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld31
Copy link

opbld31 commented Oct 10, 2022

Learn Build status updates of commit 82e81e5:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Net.Sockets/TcpClient/Overview/tcpclient.cs ✅Succeeded View
snippets/csharp/System.Net.Sockets/TcpListener/Overview/tcpserver.cs ✅Succeeded View
snippets/csharp/System.Net/HttpVersion/Overview/httpversion_version10.cs ✅Succeeded View
snippets/csharp/System.Net/WebClient/Overview/useragent.cs ✅Succeeded View
snippets/visualbasic/VS_Snippets_Remoting/HttpVersion_Version10/VB/httpversion_version10.vb ✅Succeeded View
snippets/visualbasic/VS_Snippets_Remoting/NCLWebClientUserAgent/VB/useragent.vb ✅Succeeded View
xml/System.Net.Http/ByteArrayContent.xml ✅Succeeded View
xml/System.Net.NetworkInformation/Ping.xml ✅Succeeded View
xml/System.Net/WebProxy.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@rzikm rzikm requested a review from stephentoub October 12, 2022 10:33
@rzikm rzikm force-pushed the codereview-followup branch from 82e81e5 to 2a29363 Compare November 7, 2022 09:00
@rzikm
Copy link
Member Author

rzikm commented Nov 7, 2022

bump @dotnet/ncl, please take a look.

@opbld33
Copy link

opbld33 commented Nov 7, 2022

Learn Build status updates of commit 2a29363:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System.Net.Sockets/TcpClient/Overview/tcpclient.cs ✅Succeeded View
snippets/csharp/System.Net.Sockets/TcpListener/Overview/tcpserver.cs ✅Succeeded View
snippets/csharp/System.Net/HttpVersion/Overview/httpversion_version10.cs ✅Succeeded View
snippets/visualbasic/VS_Snippets_Remoting/HttpVersion_Version10/VB/httpversion_version10.vb ✅Succeeded View
xml/System.Net.Http/ByteArrayContent.xml ✅Succeeded View
xml/System.Net.NetworkInformation/Ping.xml ✅Succeeded View
xml/System.Net/WebProxy.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@rzikm rzikm merged commit 5e04197 into dotnet:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants