Operator syntax tree two

[nojaf]

Superseded #12980.
Some more nodes were introduced to better capture operators, active patterns and partial active patterns.

Very much still a work in progress. Feedback would be welcome if there are volunteers 😊.

[nojaf]

FSharp.Core now builds so, I guess that is one step forward.
I'm currently hitting the following problem: my signature file no longer matches the implementation:
signature:

module WithSignature

val (|A|_|) : int -> string option

implementation:

module WithSignature

let (|A|_|) = function | 1 -> Some "1" | _ -> None

error:

       "C:\Users\nojaf\Projects\FSharpSampleProject\FSharpSampleProject.fsproj" (default target) (1:7) ->
       (CoreCompile target) ->
         C:\Users\nojaf\Projects\FSharpSampleProject\WithSignature.fs(3,6): error FS0034: Module 'WithSignature' contains↔    val (|A|_|) : (int -> string option)    ↔but its signature specifies↔    val (|A|_|) : int -> string option    ↔The arities in the signature and implementation differ. The signature specifies that '|A|_|' is function definition or lambda expression accepting at least 1 argument(s), but the implementation is a computed function value. To declare that a computed function value is a permitted implementation simply parenthesize its type in the signature, e.g.↔ val |A|_|: int -> (int -> int)↔instead of↔ val |A|_|: int -> int -> int. [C:\Users\nojaf\Projects\FSharpSampleProject\FSharpSampleProject.fsproj]

@auduchinok any ideas by any chance? I'm out of ideas.

The ValReprInfo of the implementation file has no implArgInfos, while the signature has one.
It fails in

fsharp/src/fsharp/SignatureConformance.fs

Lines 274 to 275 in e7289c1

	elif not (nSigArgInfos <= implArgInfos.Length && List.forall2 (fun x y -> List.length x <= List.length y) sigArgInfos (fst (List.splitAt nSigArgInfos implArgInfos))) then
	err(fun(x, y, z) -> FSComp.SR.ValueNotContainedMutabilityAritiesDiffer(x, y, z, id.idText, string nSigArgInfos, id.idText, id.idText))

but I'm unsure where the implVal.ValReprInfo is wrongly created.

[auduchinok]

FSharp.Core now builds so, I guess that is one step forward.

This is very great, congrats!

@auduchinok any ideas by any chance? I'm out of ideas.

I hope I'll be able to look into it tomorrow and will let you know

[nojaf]

I'm currently in a dilemma here:

type MyType() =
    static member (|
        AA
    |) = 2
    static member (|
        BB|_
    |) = Some 3

In the current compiler this works out fine, but given there is more information I'm not (rightly) bumping into

fsharp/src/fsharp/CheckExpressions.fs

Lines 10475 to 10487 in 34fb4ca

	let envinner =
	match apinfoOpt with
	| Some (apinfo, apOverallTy, m) ->
	if Option.isSome memberFlagsOpt || (not apinfo.IsTotal && apinfo.ActiveTags.Length > 1) then
	error(Error(FSComp.SR.tcInvalidActivePatternName(), mBinding))
	apinfo.ActiveTagsWithRanges |> List.iteri (fun i (_tag, tagRange) ->
	let item = Item.ActivePatternResult(apinfo, apOverallTy, i, tagRange)
	CallNameResolutionSink cenv.tcSink (tagRange, env.NameEnv, item, emptyTyparInst, ItemOccurence.Binding, env.AccessRights))
	{ envinner with eNameResEnv = AddActivePatternResultTagsToNameEnv apinfo envinner.eNameResEnv apOverallTy m }
	| None ->
	envinner

Where Option.isSome memberFlagsOpt is rightly true.

Concretely I'm hitting this error in:

fsharp/tests/FSharp.Compiler.ComponentTests/Conformance/LexicalFiltering/OffsideExceptions/RelaxWhitespace2.fs

Lines 1338 to 1351 in 34fb4ca

	static member (|
	AA
	|) = (|
	Lazy
	|)
	static member (|
	BB
	|) = ActivePatterns.(|
	AA
	|)
	static member (|CC|) =
	if true then ignore ActivePatterns.(|
	AA
	|)

@dsyme and others, any thoughts?

[nojaf]

Closing in favour of #13057.