Introduce SynPat.ParametersOwner. #13045
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset, the first step if you will, from #12989.
In 12989 I tried to do too much at the same time and I would like to cut it up into multiple PRs.
This first one refactors
SynPat.LongIdenttoSynPat.ParameterOwnersand take aSynPatas the name identifier.In practise, this can be
SynPat.LongIdentorSynPat.Ident.Later this could be extended to include
SynPat.OperatorandSynPat.DotGetOperator.And after that, the captured
SynOperatorNamecould also be introduced intoSynExpr.@dsyme, @vzarytovskii please let me know your thoughts on this.
I do believe this proposed route should be favoured over the alternative in #13023.
Replacing
IdentwithSynIdentOrOperatorNametakes a performance hit and it is used in a lot of places where operator names will never be valid. So, I would abandon that idea altogether.//cc @auduchinok