SynLongIdent #13057
Merged
SynLongIdent #13057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
reviewed
Apr 27, 2022
dsyme
reviewed
Apr 28, 2022
dsyme
reviewed
Apr 28, 2022
dsyme
reviewed
Apr 28, 2022
dsyme
reviewed
Apr 28, 2022
dsyme
reviewed
Apr 28, 2022
dsyme
reviewed
Apr 28, 2022
dsyme
reviewed
Apr 28, 2022
…nLongIdent. Restored SynExpr.Ident.
This was referenced May 2, 2022
Contributor
Author
|
This is ready for review and I've tested out these changes inside Fantomas. |
auduchinok
approved these changes
May 2, 2022
dsyme
reviewed
May 2, 2022
| let mLparen = mkFileIndexRange m.FileIndex m.Start (mkPos m.StartLine (m.StartColumn + 1)) | ||
| let mRparen = mkFileIndexRange m.FileIndex (mkPos m.EndLine (m.EndColumn - 1)) m.End | ||
| SynExpr.Paren(SynExpr.Ident($1), mLparen, Some mRparen, m) } | ||
| let ident, trivia = $1 |
Contributor
There was a problem hiding this comment.
Minor thing: We should gradually try to remove long chunks from pars.fsy and put them in ParseHelpers.fs. But this is by no means the worst of sins in that regard :)
dsyme
approved these changes
May 2, 2022
This was referenced May 2, 2022
charlesroddie
pushed a commit
to charlesroddie/fsharp
that referenced
this pull request
May 2, 2023
* Refactor LongIdentWithDots to LongIdentWithTrivia. * Start using IndentWithTrivia in SyntaxTree. * Address aesthetic feedback. * Refactored IdentWithTrivia and LongIdentWithTrivia to SynIdent and SynLongIdent. Restored SynExpr.Ident. * Capturing some additional IdentTrivia.OriginalNotation. * SurfaceArea 🎉 * Update operator ident nodes in ServiceUntypedParse.fs. * Fix remaining Visual Studio tests. * Change the Ident of SynPat.Named to SynIdent to capture active patterns without parameters. * Replace LongIdentWithDots function usage with SynLongIdent. * Correct notation of prefix operators.
jaccarmac
added a commit
to jaccarmac/ShenSharp
that referenced
this pull request
Nov 23, 2023
dotnet/fsharp#13057 is the PR in question; I suspect I've done something wrong as there's a whole page of errors. However, the errors don't have to do with mscorlib!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I'd like to address #11893.
The key concept is that the
Idents are enriched with additional information where applicable.@dsyme I must say this approach is growing on me.
I've addressed all the review remarks and would happily address any other feedback.
The build is green I believe, there is one error about
[error]Publishing build artifacts failed with an error: Not found PathtoPublish: D:\a\_work\1\s\artifacts\log\Releasewhich looks unrelated.