Skip to content

Catch user exceptions from source generator comparer#67459

Merged
jjonescz merged 2 commits intodotnet:mainfrom
jjonescz:67386-SG-Comparer-UserException
Mar 30, 2023
Merged

Catch user exceptions from source generator comparer#67459
jjonescz merged 2 commits intodotnet:mainfrom
jjonescz:67386-SG-Comparer-UserException

Conversation

@jjonescz
Copy link
Copy Markdown
Member

Fixes #67386.

@ghost ghost added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 23, 2023
@jjonescz jjonescz added the Feature - Source Generators Source Generators label Mar 23, 2023
@jjonescz jjonescz marked this pull request as ready for review March 23, 2023 15:51
@jjonescz jjonescz requested a review from a team as a code owner March 23, 2023 15:51
Copy link
Copy Markdown
Member

@chsienki chsienki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jjonescz jjonescz enabled auto-merge (squash) March 30, 2023 14:33
@jjonescz jjonescz merged commit 2860053 into dotnet:main Mar 30, 2023
@jjonescz jjonescz deleted the 67386-SG-Comparer-UserException branch March 30, 2023 15:34
@ghost ghost added this to the Next milestone Mar 30, 2023
@dibarbet dibarbet modified the milestones: Next, 17.7 P1 Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Feature - Source Generators Source Generators untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exception in user supplied comparer causes the generator driver to crash

4 participants