Skip to content

Switch MethodImplAttributes.Async to 0x2000 #78536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
333fred merged 1 commit into from
May 9, 2025
Merged

Switch MethodImplAttributes.Async to 0x2000 #78536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/compilers/CSharp/Runtime Async Design.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ namespace System.Runtime.CompilerServices;

public enum MethodImplOptions
{
Async = 1024
Async = 0x2000
}
```

Expand Down
2 changes: 1 addition & 1 deletion src/Compilers/CSharp/Portable/Symbols/Source/SourceMethodSymbolWithAttributes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1762,7 +1762,7 @@ internal override System.Reflection.MethodImplAttributes ImplementationAttribute
// PROTOTYPE: Use real value from MethodImplAttributes when available
Copy link
Member

@agocke agocke May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could do this now, I think. That is, look in the ref assembly for MethodImplAttributes.Async, then write that value in.

Copy link
Member Author

@333fred 333fred May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't do anything like that today. We'll just wait for the MethodImplAttributes that we consume to update.

// When a method is emitted using runtime async, we add MethodImplAttributes.Async to indicate to the
// runtime to generate the state machine
result |= (System.Reflection.MethodImplAttributes)1024;
result |= (System.Reflection.MethodImplAttributes)0x2000;
}

return result;
Expand Down
2 changes: 1 addition & 1 deletion src/Compilers/CSharp/Test/Emit/CodeGen/CodeGenAsyncTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ namespace Microsoft.CodeAnalysis.CSharp.UnitTests.CodeGen
public class CodeGenAsyncTests : EmitMetadataTestBase
{
// PROTOTYPE: Use the real value when possible
private const MethodImplAttributes MethodImplOptionsAsync = (MethodImplAttributes)1024;
private const MethodImplAttributes MethodImplOptionsAsync = (MethodImplAttributes)0x2000;
private static CSharpParseOptions WithRuntimeAsync(CSharpParseOptions options) => options.WithFeature("runtime-async", "on");

internal static string ExpectedOutput(string output, bool isRuntimeAsync = false)
Expand Down