Remove remaining PROTOTYPE pieces of `with(...)`, so it can be merged into main. #82030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

CyrusNajmabadi merged 129 commits into dotnet:features/collection-expression-arguments from CyrusNajmabadi:removePrototype

Jan 16, 2026

src/Compilers/CSharp/Portable/CSharpResources.resx

            
                      Original file line number
                      Diff line number
                      Diff line change
                  
    @@ -6789,7 +6789,7 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ
  
        <value>There is no target type for the collection expression.</value>

      </data>

      <data name="ERR_CollectionBuilderAttributeMethodNotFound" xml:space="preserve">

        <value>Could not find an accessible '{0}' method with the expected signature: a static method with a single parameter of type 'ReadOnlySpan&lt;{1}&gt;' and return type '{2}'.</value>

        <value>Could not find an accessible '{0}' method with the expected signature: a static method whose last parameter is of type 'ReadOnlySpan&lt;{1}&gt;' and return type '{2}'.</value>

      </data>

      <data name="ERR_CollectionBuilderNoElementType" xml:space="preserve">

        <value>'{0}' has a CollectionBuilderAttribute but no element type.</value>

src/Compilers/CSharp/Portable/Errors/ErrorCode.cs

-Original file line number
+Diff line change
@@ Expand Up / @@ -2454,13 +2454,12 @@ internal enum ErrorCode @@
             ERR_StructLayoutAndExtendedLayout = 9351,
             ERR_RuntimeDoesNotSupportExtendedLayoutTypes = 9352,
-            // PROTOTYPE: Renumber accordingly.
-            ERR_CollectionArgumentsMustBeFirst = 9400,
-            ERR_CollectionArgumentsNotSupportedForType = 9401,
-            ERR_CollectionArgumentsDynamicBinding = 9402,
-            ERR_CollectionArgumentsMustBeEmpty = 9403,
-            ERR_CollectionRefLikeElementType = 9404,
-            ERR_BadCollectionArgumentsArgCount = 9405,
+            ERR_CollectionArgumentsMustBeFirst = 9353,
+            ERR_CollectionArgumentsNotSupportedForType = 9354,
+            ERR_CollectionArgumentsDynamicBinding = 9355,
+            ERR_CollectionArgumentsMustBeEmpty = 9356,
+            ERR_CollectionRefLikeElementType = 9357,
+            ERR_BadCollectionArgumentsArgCount = 9358,
             // Note: you will need to do the following after adding errors:
             //  1) Update ErrorFacts.IsBuildOnlyDiagnostic (src/Compilers/CSharp/Portable/Errors/ErrorFacts.cs)
@@ Expand Down @@

src/Compilers/CSharp/Portable/xlf/CSharpResources.cs.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

src/Compilers/CSharp/Portable/xlf/CSharpResources.de.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

src/Compilers/CSharp/Portable/xlf/CSharpResources.es.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

src/Compilers/CSharp/Portable/xlf/CSharpResources.fr.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

src/Compilers/CSharp/Portable/xlf/CSharpResources.it.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

src/Compilers/CSharp/Portable/xlf/CSharpResources.ja.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

src/Compilers/CSharp/Portable/xlf/CSharpResources.ko.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

src/Compilers/CSharp/Portable/xlf/CSharpResources.pl.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

src/Compilers/CSharp/Portable/xlf/CSharpResources.pt-BR.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

src/Compilers/CSharp/Portable/xlf/CSharpResources.ru.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

src/Compilers/CSharp/Portable/xlf/CSharpResources.tr.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

src/Compilers/CSharp/Portable/xlf/CSharpResources.zh-Hans.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

src/Compilers/CSharp/Portable/xlf/CSharpResources.zh-Hant.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove remaining PROTOTYPE pieces of `with(...)`, so it can be merged into main. #82030

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Remove remaining PROTOTYPE pieces of with(...), so it can be merged into main. #82030

Uh oh!

Remove remaining PROTOTYPE pieces of with(...), so it can be merged into main. #82030

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Remove remaining PROTOTYPE pieces of `with(...)`, so it can be merged into main. #82030

Remove remaining PROTOTYPE pieces of `with(...)`, so it can be merged into main. #82030