Porting compiler tests to run on Linux by jaredpar · Pull Request #82572 · dotnet/roslyn

jaredpar · 2026-02-28T00:03:21Z

Ported a number of the CSharp tests to run on .NET Core + Linux. This will increase our cross platform test coverage which will help with agent validation on Linux.

Note: used a ralph loop for this and it worked surprisingly well. The details of the loop are in the PR (will be removed before merging).

Remove DesktopOnly restriction from VaryingCompilationReferences test. Replace MscorlibRef with compilation0.References to use the correct base references on any platform. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Remove WindowsDesktopOnly/WindowsOnly restrictions from three tests: - InvalidCharacterInPdbPath: uses Embedded PDB, not native - SwitchExpression_MethodBody_02: works with portable PDB - SyntaxOffset_OutVarInInitializers_SwitchExpression: works with portable PDB Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Remove DesktopOnly restriction from PortablePdb_DeterministicCompilationWithSJIS. Add Encoding.RegisterProvider(CodePagesEncodingProvider.Instance) for SJIS encoding availability on .NET Core. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Remove WindowsOnly restrictions from 5 of 7 EnC assembly reference tests: - ChangingCompilationDependencies - DependencyVersionWildcards_Compilation - DependencyVersionWildcards_Metadata - DependencyVersionWildcardsCollisions - CurrentCompilationVersionWildcards CompilationReferences_Less/More kept as WindowsOnly due to stream-based EmitDifference producing BadImageFormatException on portable PDB path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

… to .NET Core Remove WindowsDesktopOnly restriction - dynamic types are available on .NET Core via TargetFramework.StandardAndCSharp. The TestExecutionNeedsDesktopTypes reason was overly conservative. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

34 test files with 155 desktop/Windows-only methods identified for porting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Remove DesktopOnly restriction from all 22 test methods. These are pure compilation/diagnostic tests with no desktop-specific dependencies. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Remove DesktopOnly restriction from LongTupleDeclaration and Serialization tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Remove DesktopOnly restriction from: - CodeGenThrowTests: 3 tests - CodeGenUsingStatementTests: ObjectCreateInsideUsing - CodeGenNullCoalescingAssignmentTests: IndexerLvalue - CodeGenIterators: TestIteratorWithNullableAsCollectionVariable_Null Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Port 13 tests from DesktopOnly/WindowsOnly to Fact: - DestructorTests: 4 ported - CodeGenShortCircuitOperatorTests: 2 ported - CodeGenScriptTests: 2 ported - CodeGenDynamicTests: 1 ported - CodeGenCapturing: 3 ported (2 WindowsOnly→Fact, 1 multi-condition fix) - CodeGenOverridingAndHiding: already runs on .NET Core (ClrOnly) - CodeGenInParametersTests: already runs on .NET Core (ClrOnly) Skipped classes (cannot port): - CodeGenTryFinally: ThreadAbort not supported on .NET Core - BreakingChanges: WindowsDesktopOnly, fails on .NET Core - CodeGenLocalFunctionTests: fails on .NET Core - CodeGenDeconstructTests: fails on .NET Core Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Port 12 tests across 7 files: - CodeGenExprLambdaTests: 2 ported (AnonymousCreation, AnonTypes2) - CodeGenTests: 2 ported (TestBug15818, InitFromBlob) - CodeGenOperators: 3 ported (negative zero tests) - UnsafeTests: 2 ported (PointerArrayConversion, PointerArrayEnumerableConversion) - CodeGenExplicitImplementationTests: 1 ported - PatternTests: 1 ported (SwitchExpressionSequencePoints) - OptionalArgumentsTests: 1 ported Skipped: expression tree tests (#30160), varargs, runtime-dependent, CRLF-dependent hashes, #if NET472 blocks, RestrictedTypes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Port 4 tests from WindowsOnly to Fact: - CommandLineTests: CompilationWithWarnAsError_01, CompilationWithWarnAsError_02, PdbPathNotEmittedWithoutPdb - SarifV2ErrorLoggerTests: AnalyzerDisabledWithCommandLineOptions Remaining 103 methods skipped - genuinely Windows-specific: - Hardcoded Windows paths (C:\, backslash normalization) - Uses cmd.exe for process execution - SARIF URI formatting differences on Linux - Native PDB, NoPIA, SxS loading, locale requirements Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Port 11 additional tests by refactoring hardcoded Windows paths: - NullBaseDirectory* (3): use platform-conditional source file path - AppConfigParse: platform-conditional baseDirectory + Path.Combine - AppConfigBasicFail: Path.Combine for config file path - ParseDocAndOut/ParseErrorLogAndOut: platform-conditional baseDirectory + Path.DirectorySeparatorChar for sub-paths - SdkPathAndLibEnvVariable: already cross-platform - CompilationWithNonExistingOutPath: Path.DirectorySeparatorChar + Path.Combine - ResponseFilesWithNoconfig_02/_04: removed \r\n dependency Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Port 9 tests across Syntax and Emit3 projects: - MemberDeclarationParsingTests: ParseOverflow, ParseOverflow2 - SyntaxNormalizerTests: 2 raw string multiline tests - OutVarTests: Scope_Query_01 - AttributeTests_Assembly: Bug16465 - AttributeTests_WellKnownAttributes: TestPseudoAttributes1 - AttributeTests_CallerInfoAttributes: TestCallerMemberName_ConstructorDestructor - AttributeTests: TestWellKnownAttributeOnProperty_DynamicAttribute Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Port 8 tests across 3 files in the Semantic project: - LocalFunctionTests: LocalFunctionResetsLockScopeFlag, LocalFunctionResetsTryCatchFinallyScopeFlags, LocalFunctionDoesNotOverwriteInnerLockScopeFlag, LocalFunctionDoesNotOverwriteInnerTryCatchFinallyScopeFlags, RethrowingExceptionsInCatchInsideLocalFuncIsAllowed, RethrowingExceptionsInLocalFuncInsideCatchIsNotAllowed - OperatorTests: DynamicAmbiguousOrConversion - QueryTests: StaticTypeInFromClause Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Port 37 tests across 7 files in the Symbol project: - CustomModifiersTests: 30 tests (DesktopOnly → Fact or ClrOnly) - IndexedPropertyTests: 2 tests (ClrOnly+DesktopOnly → ClrOnly) - OverriddenOrHiddenMembersTests: 1 test (DesktopOnly+ClrOnly → ClrOnly) - GenericConstraintTests: 1 test (ClrOnly+DesktopOnly → ClrOnly) - DynamicTransformsTests: 1 test (DesktopOnly+ClrOnly → ClrOnly) - PropertyTests: 1 test (DesktopOnly → Fact) - CustomModifierCopyTests: 1 test (ClrOnly+DesktopOnly → ClrOnly) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

All 6 remaining projects (Emit3, Semantic, Symbol, Syntax, WinRT, IOperation) have been analyzed and attempted. Updated list.md and actions.md with results. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

jaredpar · 2026-03-02T18:33:29Z

copilot/actions.md

@@ -0,0 +1,586 @@
+# Porting Actions Log


Note: all files in the copilot directory will be removed before merge. I included them to give some context about how I went about this change.

jaredpar · 2026-03-02T18:37:00Z

src/Compilers/CSharp/Test/Emit2/PDB/CSharpDeterministicBuildCompilationTests.cs

        {
+#if NET
+            Encoding.RegisterProvider(CodePagesEncodingProvider.Instance);
+#endif


Considered a module initializer to just ensure this happens for all of our unit tests. This is technically impacting the process execution since it's a shared component. Happy to hear thoughts on this.

I can't say I even understand what this is doing. It should definitely be documented here, at the very least.

jaredpar · 2026-03-02T18:38:29Z

@roslyn-compiler PTAL

333fred

Think the ralph loop needs to be convinced to go again. There's a few things in #79615 that should be able to be updated as well.

333fred · 2026-03-02T20:53:25Z

src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs

        public void NullBaseDirectoryNotAddedToKeyFileSearchPaths()
        {
-            var parser = CSharpCommandLineParser.Default.Parse(new[] { "c:/test.cs" }, baseDirectory: null, SdkDirectory);
+            var sourceFile = ExecutionConditionUtil.IsWindows ? "c:/test.cs" : Path.Combine(Path.GetTempPath(), "test.cs");


Can't say I like the use of Path.GetTempPath() in these. Can we just have it do /test.cs, for this and other added uses?

We should be able to do that.

333fred · 2026-03-02T20:55:55Z

src/Compilers/CSharp/Test/Emit2/Emit/EditAndContinue/SymbolMatcherTests.cs

+            var lib0Ref = lib0.ToMetadataReference();
+            var compilation0 = CreateCompilation(source, new[] { lib0Ref }, options: TestOptions.DebugDll);
+            var compilation1 = compilation0.WithSource(source).WithReferences(compilation0.References.Where(r => r != lib0Ref).Append(lib1.ToMetadataReference()));


I'm not sure I see why this is needed at all, tbh. Seems like the old code should run just fine.

333fred · 2026-03-02T20:56:58Z

src/Compilers/CSharp/Test/Emit2/PDB/CSharpDeterministicBuildCompilationTests.cs

        {
+#if NET
+            Encoding.RegisterProvider(CodePagesEncodingProvider.Instance);
+#endif


I can't say I even understand what this is doing. It should definitely be documented here, at the very least.

jaredpar and others added 5 commits February 27, 2026 23:44

github-actions bot added the Area-Compilers label Feb 28, 2026

jaredpar and others added 13 commits February 28, 2026 00:09

Add Microsoft.CodeAnalysis.CSharp.Emit.UnitTests to porting list

6b2c0e2

34 test files with 155 desktop/Windows-only methods identified for porting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix

42e0b74

Port PrivateProtected tests to .NET Core

a185ee5

Remove DesktopOnly restriction from all 22 test methods. These are pure compilation/diagnostic tests with no desktop-specific dependencies. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Port CodeGenTupleTests to .NET Core

e0bf160

Remove DesktopOnly restriction from LongTupleDeclaration and Serialization tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Update tracking for all remaining CSharp test projects

ccbd5c2

All 6 remaining projects (Emit3, Semantic, Symbol, Syntax, WinRT, IOperation) have been analyzed and attempted. Updated list.md and actions.md with results. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

jaredpar commented Mar 2, 2026

View reviewed changes

jaredpar marked this pull request as ready for review March 2, 2026 18:38

jaredpar requested a review from a team as a code owner March 2, 2026 18:38

333fred reviewed Mar 2, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Porting compiler tests to run on Linux#82572

Porting compiler tests to run on Linux#82572
jaredpar wants to merge 18 commits intomainfrom
port

jaredpar commented Feb 28, 2026 •

edited

Loading

Uh oh!

jaredpar Mar 2, 2026

Uh oh!

jaredpar Mar 2, 2026

Uh oh!

333fred Mar 2, 2026

Uh oh!

jaredpar commented Mar 2, 2026

Uh oh!

333fred left a comment

Uh oh!

333fred Mar 2, 2026

Uh oh!

jaredpar Mar 10, 2026

Uh oh!

333fred Mar 2, 2026

Uh oh!

333fred Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jaredpar commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaredpar Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

jaredpar Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

333fred Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

jaredpar commented Mar 2, 2026

Uh oh!

333fred left a comment

Choose a reason for hiding this comment

Uh oh!

333fred Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

jaredpar Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

333fred Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

333fred Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jaredpar commented Feb 28, 2026 •

edited

Loading