Handle Windows backslashes in ConfigurationUpdater header regex construction#83646
Draft
Copilot wants to merge 3 commits into
Draft
Handle Windows backslashes in ConfigurationUpdater header regex construction#83646Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Agent-Logs-Url: https://github.com/dotnet/roslyn/sessions/44f1c0cb-6ee3-44a5-991f-964315a06c1d Co-authored-by: phil-allen-msft <32652734+phil-allen-msft@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/roslyn/sessions/44f1c0cb-6ee3-44a5-991f-964315a06c1d Co-authored-by: phil-allen-msft <32652734+phil-allen-msft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix invalid regex handling for Windows paths in ConfigurationUpdater
Handle Windows backslashes in ConfigurationUpdater header regex construction
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigurationUpdaterwas building a regex directly from.editorconfigheader text and did not handle Windows-style\path separators. In VS Code quick-fix flows (for analyzer severity configuration), this could throwRegexParseException(for example,\hescape) instead of applying/updating configuration.Product fix: normalize header path separators before regex translation
ConfigurationUpdater.CheckIfRuleExistsAndReplaceInFile, header path text now normalizes\to/before wildcard/extension regex expansion.Regression coverage: backslash-heavy header scenario
CategoryBasedSeverityConfigurationTeststo cover a header containing Windows-style backslashes.