WIP - Move ICsharpCode.Decompiler.dll and e_sqlite3.dll into the 3rd Party Sign list#83735
Open
phil-allen-msft wants to merge 2 commits into
Open
WIP - Move ICsharpCode.Decompiler.dll and e_sqlite3.dll into the 3rd Party Sign list#83735phil-allen-msft wants to merge 2 commits into
phil-allen-msft wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Roslyn’s signing configuration so ICSharpCode.Decompiler.dll and e_sqlite3.dll are treated as third party binaries to be signed with the 3PartySHA2 certificate, and removes now-redundant explicit mapping from the DevDiv insertion file builder.
Changes:
- Added
ICSharpCode.Decompiler.dlland platform-specifice_sqlite3.dllpaths to the3PartySHA2signing list and removed them from theexcludelist. - Removed an explicit
ICSharpCode.Decompiler.dllentry fromBuildDevDivInsertionFiles.vbsince it is now covered bySignToolData.json.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Setup/DevDivInsertionFiles/BuildDevDivInsertionFiles.vb | Removes explicit ICSharpCode.Decompiler.dll mapping now that it’s in SignToolData. |
| build/config/SignToolData.json | Adds third party signing entries for ICSharpCode.Decompiler.dll and e_sqlite3.dll, and updates excludes accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+167
to
+168
| "Vsix\\VisualStudioSetup\\x86\\e_sqlite3.dll", | ||
| "Vsix\\VisualStudioSetup\\x64\\e_sqlite3.dll", |
| "values": [ | ||
| "Dlls\\Diagnostics\\Nerdbank.FullDuplexStream.dll", | ||
| "Vsix\\VisualStudioSetup\\x86\\e_sqlite3.dll", | ||
| "Vsix\\VisualStudioSetup\\x64\\e_sqlite3.dll", |
| @@ -72,7 +72,6 @@ Public Class BuildDevDivInsertionFiles | |||
| "SQLitePCLRaw.batteries_v2.dll", | |||
| "SQLitePCLRaw.core.dll", | |||
| "SQLitePCLRaw.provider.e_sqlite3.dll", | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move ICsharpCode.Decompiler.dll and e_sqlite3.dll into the 3rd Party Sign list
Microsoft Reviewers: Open in CodeFlow