There are 45 [ActiveIssue] attributes in Microsoft.Extensions tests that point to issues that are no longer active (i.e. the issues are closed). I think these tests should be reactivated, if possible. If removing some [ActiveIssue] is more complicated, we can create a dedicated issue for it (or ignore it for now).
Specifically:
| Closed issue |
Affected tests/scope |
| runtime#35970 |
Microsoft.Extensions.Caching.Memory.Tests — assembly-wide, limited to the Mono runtime |
| runtime#33894 |
ServiceProviderCompilationTest — class-wide, limited to the Mono runtime; CompilesInLimitedStackSpace is also separately marked for Mono |
| runtime#34091 |
10 tests in LoggerFactoryExtensionsTest and LoggerTest |
| runtime#37669, runtime#73432 |
XmlConfigurationTest.LoadKeyValuePairsFromValidEncryptedXml |
| runtime#42036 |
CanSetValuesAndReloadValues, CreatingOptionalFileInNonExistentDirectoryWillReload, DeletingFilesThatRedefineKeysWithReload, DeletingFileWillReload, CreatingWritingDeletingCreatingFileWillReload |
| runtime#43411 |
DI.External.Tests — assembly-wide, limited to Browser |
| runtime#48696 |
HostTests.CreateDefaultBuilder_ConfigJsonDoesNotReload |
| runtime#50867 |
Three Configuration.Ini tests in IniConfigurationExtensionsTest and IniConfigurationTest |
| runtime#50872 |
ReadsRuntimeTargetInfoWithCommentsIsInvalid, RejectsMissingLibrary |
| runtime#50873 |
Six Http tests across DefaultHttpMessageHandlerBuilderTest, HttpMessageHandlerBuilderTest, and HttpClientFactoryServiceCollectionExtensionsTest |
| runtime#50875 |
Five Logging tests in LoggerFilterTest and LoggerMessageTest |
| runtime#50877 |
ConfigureOptionsThrowsWithAction, ConfigureOptionsThrowsIfNothingFound |
| runtime#52062 |
ConfigurationBindingGeneratorTests, LoggerMessageGeneratorEmitterTests, and LoggerMessageGeneratorParserTests — class-wide, limited to Browser |
| runtime#52319 |
FileConfigurationProviderTest.ProviderThrowsInvalidDataExceptionWhenLoadFails |
| roslyn#52527 |
LoggerMessageGeneratedCodeTests.MessageTests_SuppressWarning_WarnAsError_NoError |
There are 45
[ActiveIssue]attributes in Microsoft.Extensions tests that point to issues that are no longer active (i.e. the issues are closed). I think these tests should be reactivated, if possible. If removing some[ActiveIssue]is more complicated, we can create a dedicated issue for it (or ignore it for now).Specifically:
Microsoft.Extensions.Caching.Memory.Tests— assembly-wide, limited to the Mono runtimeServiceProviderCompilationTest— class-wide, limited to the Mono runtime;CompilesInLimitedStackSpaceis also separately marked for MonoLoggerFactoryExtensionsTestandLoggerTestXmlConfigurationTest.LoadKeyValuePairsFromValidEncryptedXmlCanSetValuesAndReloadValues,CreatingOptionalFileInNonExistentDirectoryWillReload,DeletingFilesThatRedefineKeysWithReload,DeletingFileWillReload,CreatingWritingDeletingCreatingFileWillReloadDI.External.Tests— assembly-wide, limited to BrowserHostTests.CreateDefaultBuilder_ConfigJsonDoesNotReloadIniConfigurationExtensionsTestandIniConfigurationTestReadsRuntimeTargetInfoWithCommentsIsInvalid,RejectsMissingLibraryDefaultHttpMessageHandlerBuilderTest,HttpMessageHandlerBuilderTest, andHttpClientFactoryServiceCollectionExtensionsTestLoggerFilterTestandLoggerMessageTestConfigureOptionsThrowsWithAction,ConfigureOptionsThrowsIfNothingFoundConfigurationBindingGeneratorTests,LoggerMessageGeneratorEmitterTests, andLoggerMessageGeneratorParserTests— class-wide, limited to BrowserFileConfigurationProviderTest.ProviderThrowsInvalidDataExceptionWhenLoadFailsLoggerMessageGeneratedCodeTests.MessageTests_SuppressWarning_WarnAsError_NoError