Skip to content

Remove /fp:fast ceil/floor workarounds from floatdouble.cpp and floatsingle.cpp #127325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+0 −33
Open

Remove /fp:fast ceil/floor workarounds from floatdouble.cpp and floatsingle.cpp #127325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
096b85e
Initial plan
Copilot Apr 23, 2026
a497b08
Remove /fp:fast ceil/floor workarounds from floatdouble.cpp and float…
Copilot Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions src/coreclr/vm/floatdouble.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,6 @@ FCIMPL1_V(double, COMDouble::Cbrt, double x)
return cbrt(x);
FCIMPLEND

#if defined(_MSC_VER) && defined(TARGET_AMD64)
// The /fp:fast form of `ceil` for AMD64 does not correctly handle: `-1.0 < value <= -0.0`
// https://github.com/dotnet/runtime/issues/11003
#pragma float_control(push)
#pragma float_control(precise, on)
#endif

/*====================================Ceil======================================
**
==============================================================================*/
Expand All @@ -130,10 +123,6 @@ FCIMPL1_V(double, COMDouble::Ceil, double x)
return ceil(x);
Comment thread
tannergooding marked this conversation as resolved.
FCIMPLEND

#if defined(_MSC_VER) && defined(TARGET_AMD64)
#pragma float_control(pop)
#endif

/*=====================================Cos======================================
**
==============================================================================*/
Expand Down Expand Up @@ -161,13 +150,6 @@ FCIMPL1_V(double, COMDouble::Exp, double x)
return exp(x);
FCIMPLEND

#if defined(_MSC_VER) && defined(TARGET_X86)
// The /fp:fast form of `floor` for x86 does not correctly handle: `-0.0`
// https://github.com/dotnet/runtime/issues/11003
#pragma float_control(push)
#pragma float_control(precise, on)
#endif

/*====================================Floor=====================================
**
==============================================================================*/
Expand All @@ -177,10 +159,6 @@ FCIMPL1_V(double, COMDouble::Floor, double x)
return floor(x);
Comment thread
tannergooding marked this conversation as resolved.
FCIMPLEND

#if defined(_MSC_VER) && defined(TARGET_X86)
#pragma float_control(pop)
#endif

/*=====================================FusedMultiplyAdd==========================
**
==============================================================================*/
Expand Down
11 changes: 0 additions & 11 deletions src/coreclr/vm/floatsingle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,6 @@ FCIMPL1_V(float, COMSingle::Cbrt, float x)
return cbrtf(x);
FCIMPLEND

#if defined(_MSC_VER) && defined(TARGET_AMD64)
// The /fp:fast form of `ceilf` for AMD64 does not correctly handle: `-1.0 < value <= -0.0`
// https://github.com/dotnet/runtime/issues/11003
#pragma float_control(push)
#pragma float_control(precise, on)
#endif

/*====================================Ceil======================================
**
==============================================================================*/
Expand All @@ -116,10 +109,6 @@ FCIMPL1_V(float, COMSingle::Ceil, float x)
return ceilf(x);
Comment thread
tannergooding marked this conversation as resolved.
FCIMPLEND

#if defined(_MSC_VER) && defined(TARGET_AMD64)
#pragma float_control(pop)
#endif

/*=====================================Cos======================================
**
==============================================================================*/
Expand Down
Loading