Add MachO composite Crossgen2 test jobs for OSX#127770
Open
jtschuster wants to merge 2 commits intodotnet:mainfrom
Open
Add MachO composite Crossgen2 test jobs for OSX#127770jtschuster wants to merge 2 commits intodotnet:mainfrom
jtschuster wants to merge 2 commits intodotnet:mainfrom
Conversation
…tputFormat param through pipelines
Member
Author
|
/azp run runtime-coreclr crossgen2-composite |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the CoreCLR crossgen2 composite test pipelines to add macOS (x64/arm64) jobs that run ReadyToRun composite tests with Crossgen2 emitting Mach-O output (via a new crossgen2OutputFormat pipeline parameter that flows into Helix as CrossGen2OutputFormat).
Changes:
- Add
crossgen2OutputFormatparameter plumbing through runtime test job templates into Helix/MSBuild so Helix work items can exportCrossGen2OutputFormat. - Add new macOS composite test matrix entries in
crossgen2-outerloop.ymlandcrossgen2-composite.ymlthat setcrossgen2OutputFormat: macho. - Adjust log naming in
run-test-job.ymlto distinguish output-format-specific runs.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/Common/helixpublishwitharcade.proj | Passes CrossGen2OutputFormat into per-scenario child MSBuild invocations and exports it for non-Windows Helix runs. |
| eng/pipelines/coreclr/crossgen2-outerloop.yml | Adds new macOS outerloop composite Mach-O jobs. |
| eng/pipelines/coreclr/crossgen2-composite.yml | Adds new macOS innerloop composite Mach-O jobs. |
| eng/pipelines/common/templates/runtimes/send-to-helix-step.yml | Adds crossgen2OutputFormat template parameter and maps it into the Helix MSBuild environment. |
| eng/pipelines/common/templates/runtimes/run-test-job.yml | Adds crossgen2OutputFormat job parameter, tweaks log prefixing, and forwards the value to Helix. |
| eng/pipelines/common/templates/runtimes/build-runtime-tests-and-send-to-helix.yml | Adds crossgen2OutputFormat parameter and forwards it into the Helix send step. |
| PublishTestResults=$(_PublishTestResults); | ||
| RunCrossGen2=$(_RunCrossGen2); | ||
| CompositeBuildMode=$(_CompositeBuildMode); | ||
| CrossGen2OutputFormat=$(_Crossgen2OutputFormat); |
Member
Author
|
/azp run runtime-coreclr crossgen2-composite |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 tasks
Comment on lines
649
to
652
| <HelixPreCommand Include="export RunCrossGen2=1" Condition=" '$(RunCrossGen2)' == 'true' " /> | ||
| <HelixPreCommand Include="export CompositeBuildMode=1" Condition=" '$(CompositeBuildMode)' == 'true' " /> | ||
| <HelixPreCommand Include="export CrossGen2OutputFormat=$(CrossGen2OutputFormat)" Condition=" '$(CrossGen2OutputFormat)' != '' " /> | ||
| <HelixPreCommand Include="export RunningLongGCTests=1" Condition=" '$(LongRunningGCTests)' == 'true' " /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a crossgen job to output a MachO object file and run tests in the crossgen-composite pipeline.