Add CompositeMLDsa CNG (NCrypt) by PranavSenthilnathan · Pull Request #130053 · dotnet/runtime

PranavSenthilnathan · 2026-06-30T18:47:11Z

Wires up Composite ML-DSA CNG support.

The APIs in #130052 is pending approval so they're internal in this PR.

PKCS8 export does not work in Windows for Composite ML-DSA (yet), so encrypted export only keys can't currently be exported. Also, PKCS8 export is done by exporting the private key instead.

dotnet-policy-service · 2026-06-30T18:48:35Z

Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security
See info in area-owners.md if you want to be subscribed.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.

Add CompositeMLDsa CNG (NCrypt)

b6b9e66

PranavSenthilnathan self-assigned this Jun 30, 2026

Copilot AI review requested due to automatic review settings June 30, 2026 18:47

PranavSenthilnathan added the area-System.Security label Jun 30, 2026

Copilot started reviewing on behalf of PranavSenthilnathan June 30, 2026 18:48 View session

Copilot AI reviewed Jun 30, 2026

PranavSenthilnathan requested a review from Copilot June 30, 2026 22:58

Copilot started reviewing on behalf of PranavSenthilnathan June 30, 2026 22:58 View session

Copilot AI reviewed Jun 30, 2026

View reviewed changes

Comment thread src/libraries/System.Security.Cryptography/ref/System.Security.Cryptography.cs

Comment thread ...urity/Cryptography/AlgorithmImplementations/CompositeMLDsa/CompositeMLDsaCngTests.Windows.cs Outdated

vcsjones reviewed Jul 1, 2026

View reviewed changes

Comment thread src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaCng.Windows.cs Outdated

vcsjones reviewed Jul 1, 2026

View reviewed changes

Comment thread src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaCng.Windows.cs

bartonjs reviewed Jul 2, 2026

View reviewed changes

PranavSenthilnathan and others added 3 commits July 7, 2026 03:58

Merge remote-tracking branch 'upstream/main' into cmldsa-ncrypt

ec19e43

Address some feedback

2b558c6

remaining feedback

26707b4

Copilot AI review requested due to automatic review settings July 7, 2026 08:08

Copilot started reviewing on behalf of PranavSenthilnathan July 7, 2026 08:09 View session

Copilot AI reviewed Jul 7, 2026

View reviewed changes

Comment thread src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaCng.Windows.cs

Comment thread src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaCng.Windows.cs

Remove experimental from internal members

a5ae831

Copilot AI review requested due to automatic review settings July 13, 2026 21:19

Copilot started reviewing on behalf of PranavSenthilnathan July 13, 2026 21:19 View session

Copilot AI reviewed Jul 13, 2026

View reviewed changes

Comment thread src/libraries/Common/src/System/Security/Cryptography/CompositeMLDsaCng.Windows.cs

Comment thread src/libraries/System.Security.Cryptography/src/Resources/Strings.resx Outdated

Comment thread src/libraries/Microsoft.Bcl.Cryptography/src/Resources/Strings.resx Outdated

Fix BOM

e73e7e4

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 13, 2026 21:49

Copilot started reviewing on behalf of PranavSenthilnathan July 13, 2026 21:50 View session

Copilot AI reviewed Jul 13, 2026

View reviewed changes

PranavSenthilnathan marked this pull request as ready for review July 13, 2026 22:00

This was referenced Jul 14, 2026

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host. dotnet/dnceng#5922

Open

build-analysis Bot mentioned this pull request Jul 14, 2026

browser-wasm linux Release LibraryTests queues timing out #117974

Open

bartonjs approved these changes Jul 14, 2026

View reviewed changes

Merge branch 'main' into cmldsa-ncrypt

66daff6

Copilot AI review requested due to automatic review settings July 14, 2026 17:08

PranavSenthilnathan enabled auto-merge (squash) July 14, 2026 17:08

Copilot started reviewing on behalf of PranavSenthilnathan July 14, 2026 17:08 View session

Copilot AI reviewed Jul 14, 2026

View reviewed changes

Uh oh!

Conversation

PranavSenthilnathan commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-service Bot commented Jun 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PranavSenthilnathan commented Jun 30, 2026 •

edited

Loading