Open
Remove stale arcade#7585 comments in System.Net.Http#130477
Conversation
Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
MihaZupan
July 10, 2026 11:22
View session
MihaZupan
approved these changes
Jul 10, 2026
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a stale/misleading comment block that claimed [UnsupportedOSPlatform(...)] attributes were commented out and would break API compat, even though the attributes are present and applied. This is a low-risk, comment-only cleanup in System.Net.Http that helps keep the codebase accurate and reduces confusion for future maintainers.
Changes:
- Removed the obsolete “arcade#7585 / API compat will fail” comment above
Send/SendAsyncoverrides in the mainHttpClientHandlerimplementation. - Removed the same obsolete comment in the AnyMobile variant.
- Removed the same obsolete comment in the
System.Net.Httpref assembly source (no API surface change).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Net.Http/src/System/Net/Http/HttpClientHandler.cs | Deletes stale comment above Send override; attributes/code remain unchanged. |
| src/libraries/System.Net.Http/src/System/Net/Http/HttpClientHandler.AnyMobile.cs | Deletes same stale comment in mobile-specific handler path. |
| src/libraries/System.Net.Http/ref/System.Net.Http.cs | Deletes same stale comment in ref source near the Send override. |
This was referenced Jul 10, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three files carried a comment claiming
[UnsupportedOSPlatform(...)]attributes were commented out due to dotnet/arcade#7585, warning that "API compat will fail until this is fixed." The attributes are in fact present and applied, so the comment is stale and misleading.Send/SendAsyncoverrides in:src/libraries/System.Net.Http/ref/System.Net.Http.cssrc/libraries/System.Net.Http/src/System/Net/Http/HttpClientHandler.cssrc/libraries/System.Net.Http/src/System/Net/Http/HttpClientHandler.AnyMobile.csComment-only change; the platform attributes and surrounding code are untouched.