Use impInlineRoot()->compIsAsync() in fgGetStaticsCCtorHelper#130536
Merged
Conversation
Co-authored-by: jakobbotsch <7887810+jakobbotsch@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jakobbotsch
July 10, 2026 23:42
View session
github-actions
Bot
added
the
area-CodeGen-coreclr
Member
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an inlining-context bug in the JIT’s fgGetStaticsCCtorHelper helper typing logic by ensuring the “is async” predicate is evaluated on the inline root compiler, not the current (possibly-inlinee) compiler.
Changes:
- Switch the pinned statics base helper return type decision from
compIsAsync()toimpInlineRoot()->compIsAsync()so inlinees imported into async roots get the intendedTYP_BYREFtyping.
Member
|
/azp run runtime-coreclr jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
AndyAyersMS
reviewed
Jul 11, 2026
This was referenced Jul 11, 2026
Open
Member
|
PTAL @dotnet/jit-contrib Failures are timeouts. |
jakobbotsch
approved these changes
Jul 13, 2026
EgorBo
approved these changes
Jul 13, 2026
Member
|
/ba-g Timeouts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fgGetStaticsCCtorHelpertypes the pinned statics base helpers asTYP_BYREFin async methods so they get "killed across suspensions" behavior and byref-typed derived addresses. The async predicate usedcompIsAsync(), which reflects the current Compiler rather than the root being compiled — so an inlinee imported into an async root (the inlinee is not itself async) could be mistyped asTYP_I_IMPL.src/coreclr/jit/flowgraph.cpp: route the async check through the inline root:type = impInlineRoot()->compIsAsync() ? TYP_BYREF : TYP_I_IMPL;