Set minimum ISAs when compiling native code#130556
Open
MichalPetryka wants to merge 3 commits into
Open
Conversation
Match native compiler configuration with https://learn.microsoft.com/en-us/dotnet/core/compatibility/jit/11/minimum-hardware-requirements
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Member
|
I think it'd be better to place them near: runtime/eng/native/configurecompiler.cmake Lines 895 to 913 in a7ed27b |
Member
|
I believe we explicitly wanted to wait at least 1 release so that any users got a clear error message and we didn't see big perf wins for the JIT or VM, with the GC already opportunistically using things like LSE But, I'll defer to Jan |
This was referenced Jul 12, 2026
Open
Member
|
Related to #118101 |
Member
Yes, I makes sense to have all baselines together. |
jkotas
reviewed
Jul 12, 2026
| endif() | ||
| elseif (CLR_CMAKE_TARGET_ARCH_ARM64) | ||
| if(CLR_CMAKE_HOST_WIN32) | ||
| add_compile_options($<$<COMPILE_LANGUAGE:C,CXX>:/arch:armv8.0+lse>) |
Member
There was a problem hiding this comment.
This should set LSE_INSTRUCTIONS_ENABLED_BY_DEFAULT define as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match native compiler configuration with .NET 11.
For MSVC see x64 and ARM64, for Unixes see GCC.
@am11 Is this the right place for this? I found no usages of
/archor-marchanywhere so I just put this here.cc @jkotas @tannergooding @EgorBo any reason why we wouldn't do this?