Re-enable assert for R2R PE mapping failure on OSX#130638
Draft
elinor-fung with Copilot wants to merge 2 commits into
Draft
Re-enable assert for R2R PE mapping failure on OSX#130638elinor-fung with Copilot wants to merge 2 commits into
elinor-fung with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Reenable assert for R2R PE mapping failure on OSX
Re-enable assert for R2R PE mapping failure on OSX
Jul 13, 2026
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assert detecting suspicious R2R PE mapping failures on Unix was temporarily disabled on OSX (PR #68845) while a fix propagated through SDK/published builds. That fix has since landed, so the assert can be re-enabled. Also update the condition to handle when R2R is not allowed for the image even if the header exists.