Allow trimming NativeRuntimeEventSource#130663
Open
MichalStrehovsky wants to merge 1 commit into
Open
Conversation
Constant propagation cannot see through the local assignments/reassignments. Matches the existing patterns at https://github.com/dotnet/runtime/blob/f2b30309fd488f1c3fd41c18723a7c80a81f4c67/src/libraries/System.Private.CoreLib/src/System/Threading/Lock.cs#L696-L697
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CoreLib’s threading event emission sites to include an additional NativeRuntimeEventSource.Log.IsEnabled() guard so the ILLink substitutions for EventSource.IsEnabled() (when EventSource.IsSupported is feature-switched off) can more reliably trim away the NativeRuntimeEventSource-dependent code, even when existing boolean locals are reassigned.
Changes:
- Add
&& NativeRuntimeEventSource.Log.IsEnabled()toWaitHandlewait start/stop event emission guards. - Add
&& NativeRuntimeEventSource.Log.IsEnabled()toLockcontention event emission guards (start/stop/created).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Private.CoreLib/src/System/Threading/WaitHandle.cs | Adds an extra IsEnabled() guard around wait ETW/EventPipe event writes to improve trim-friendliness under EventSource.IsSupported=false. |
| src/libraries/System.Private.CoreLib/src/System/Threading/Lock.cs | Adds an extra IsEnabled() guard around contention event writes to match existing trim-friendly patterns in this file. |
jkotas
approved these changes
Jul 14, 2026
This was referenced Jul 14, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constant propagation cannot see through the local assignments/reassignments.
Matches the existing patterns at
runtime/src/libraries/System.Private.CoreLib/src/System/Threading/Lock.cs
Lines 696 to 697 in f2b3030