Skip single-connect test on Apple mobile CoreCLR#130674
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2b951d28-c99d-4820-9a3d-dbd6fa51fc74
|
Azure Pipelines: Successfully started running 3 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates System.Net.Sockets functional tests to avoid long/hanging multi-connect failure scenarios (notably on Apple platforms) by releasing PortBlocker’s shadow socket before attempting the “first address fails” connect path, and by running the affected scenarios in the existing non-parallel test collection to reduce endpoint contention.
Changes:
- Moved multi-connect option preservation tests (keep-alive, linger, misc) into the existing
Connect_NonParalleltest base. - Updated the multi-connect “first failure” setup to dispose
PortBlocker.SecondarySocketbefore attempting the failing connect. - Added
ConnectCancellableTask_NonParallelso the non-parallel connect test matrix still covers the cancellable task helper.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Net.Sockets/tests/FunctionalTests/Connect.cs | Moves multi-connect tests into non-parallel collection and releases PortBlocker shadow socket pre-connect to avoid OS-level TCP timeout hangs. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
kotlarmilos
marked this pull request as draft
July 14, 2026 13:35
Member
Author
|
/azp run runtime-ioslike |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This was referenced Jul 14, 2026
Open
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a14ecc81-8876-41c9-96ab-ee684e029497
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a14ecc81-8876-41c9-96ab-ee684e029497
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a14ecc81-8876-41c9-96ab-ee684e029497
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a14ecc81-8876-41c9-96ab-ee684e029497
kotlarmilos
changed the title
Member
Author
|
/azp run runtime-ioslike |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Member
Author
|
System.Net.Sockets.Tests passed on Apple mobile |
kotlarmilos
marked this pull request as ready for review
July 15, 2026 14:26
|
Azure Pipelines: Successfully started running 3 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
akoeplinger
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This skips
SingleConnect_ExposeHandle_SecondAttemptThrowsPNSEOnUnixon Apple mobile CoreCLR because connecting to a bound but non-listening socket waits for the platform TCP timeout and causes theSystem.Net.Sockets.Testswork item to exceed the XHarness timeout. Other platforms and runtimes continue to run the test through anActiveIssueattribute scoped toPlatformDetection.IsAppleMobileandPlatformDetection.IsCoreCLR.Contributes to #124344.