Remove unnecessary DisablePackageBaselineValidation from projects#130701
Merged
Conversation
akoeplinger
commented
Jul 14, 2026
akoeplinger
commented
Member
- System.Linq.AsyncEnumerable already shipped a stable version
- Microsoft.NET.Runtime.WebAssembly.Templates can't be validated
- Mono.Linker doesn't actually ship and we already set DisablePackageBaselineValidation in that case in eng/packaging.targets
- System.Linq.AsyncEnumerable already shipped a stable version - Microsoft.NET.Runtime.WebAssembly.Templates can't be validated - Mono.Linker doesn't actually ship and we already set DisablePackageBaselineValidation in that case in eng/packaging.targets
akoeplinger
temporarily deployed
to
copilot-pat-pool
July 14, 2026 17:21 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
akoeplinger
temporarily deployed
to
copilot-pat-pool
July 14, 2026 17:21 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
github-actions
Bot
added
the
area-Tools-ILLink
|
Azure Pipelines: Successfully started running 4 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
dotnet-policy-service
Bot
added
the
linkable-framework
akoeplinger
had a problem deploying
to
copilot-pat-pool
July 14, 2026 17:22 — with
GitHub Actions
Failure
GitHub Actions
Failure
akoeplinger
added
area-Infrastructure-libraries
and removed
linkable-framework
akoeplinger
temporarily deployed
to
copilot-pat-pool
July 14, 2026 17:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
dotnet-policy-service
Bot
added
the
linkable-framework
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies package baseline validation configuration by removing redundant per-project DisablePackageBaselineValidation settings where they’re no longer needed (or already enforced globally), and clarifies when the property is still required.
Changes:
- Removed
DisablePackageBaselineValidationfromSystem.Linq.AsyncEnumerablenow that it can participate in baseline validation. - Removed redundant
DisablePackageBaselineValidationfromMono.Linker(baseline validation is already disabled forIsShipping=falseviaeng/packaging.targets). - Added an explanatory comment for why baseline validation remains disabled for the WebAssembly templates package, and updated the project guidelines accordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tools/illink/src/linker/Mono.Linker.csproj | Removes redundant baseline-validation disable; project is already covered by IsShipping=false logic in packaging targets. |
| src/mono/wasm/templates/Microsoft.NET.Runtime.WebAssembly.Templates.csproj | Keeps baseline validation disabled and documents why it can’t be validated against the shared baseline version. |
| src/libraries/System.Linq.AsyncEnumerable/src/System.Linq.AsyncEnumerable.csproj | Re-enables baseline validation by removing the temporary disable property. |
| docs/coding-guidelines/project-guidelines.md | Updates guidance to describe the property usage without pointing to a now-outdated example link. |
pavelsavara
approved these changes
Jul 14, 2026
akoeplinger
temporarily deployed
to
copilot-pat-pool
July 14, 2026 17:24 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
akoeplinger
temporarily deployed
to
copilot-pat-pool
July 14, 2026 17:24 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
ViktorHofer
approved these changes
Jul 14, 2026
sbomer
approved these changes
Jul 14, 2026
Member
Author
|
/ba-g unrelated infrastructure timeouts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.