Skip to content

[release/10.0] Update dependencies from dotnet/icu - #130746

Merged
mrek-msft merged 1 commit into
release/10.0from
darc-release/10.0-4d24a1a3-63ec-46ab-926d-7999a668cb36
Jul 21, 2026
Merged

[release/10.0] Update dependencies from dotnet/icu#130746
mrek-msft merged 1 commit into
release/10.0from
darc-release/10.0-4d24a1a3-63ec-46ab-926d-7999a668cb36

Conversation

@dotnet-maestro

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/icu

On relative base path root
Microsoft.NETCore.Runtime.ICU.Transport From Version 10.0.0-rtm.26357.3 -> To Version 10.0.0-rtm.26364.2
@github-actions github-actions Bot added the area-codeflow for labeling automated codeflow label Jul 15, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@github-actions

github-actions Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Workflow state for the Holistic Review Orchestrator.

{
  "version": 5,
  "last_dispatched_commit": "1111a238ee095802c4264c78eb1ada208bd8537b",
  "last_dispatched_base_ref": "release/10.0",
  "last_dispatched_base_sha": "6d9e1b3058c87cb4ba51e2b5f160e098819a5ad2",
  "last_reviewed_commit": "1111a238ee095802c4264c78eb1ada208bd8537b",
  "last_reviewed_base_ref": "release/10.0",
  "last_reviewed_base_sha": "6d9e1b3058c87cb4ba51e2b5f160e098819a5ad2",
  "last_recorded_worker_run_id": "29684006469",
  "review_attempt_commit": "",
  "review_attempt_base_ref": "",
  "review_attempt_count": 0,
  "max_review_attempts": 5,
  "review_history_format": "holistic-review-disclosure-v1",
  "review_history": [
    {
      "commit": "1111a238ee095802c4264c78eb1ada208bd8537b",
      "review_id": 4730631013
    }
  ]
}

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holistic Review

Motivation: This is an automated Maestro dependency-codeflow PR for the release/10.0 branch that updates Microsoft.NETCore.Runtime.ICU.Transport from 10.0.0-rtm.26357.3 to 10.0.0-rtm.26364.2, flowing a new build from https://github.com/dotnet/icu (SHA 0f2ad524e8e5c745ecd62b757387c62a780e3c3e).

Approach: The change is confined to the two dependency-tracking files that darc updates: eng/Version.Details.props (the MicrosoftNETCoreRuntimeICUTransportPackageVersion property) and eng/Version.Details.xml (the matching Microsoft.NETCore.Runtime.ICU.Transport Version/Sha). The version and SHA are updated consistently across both files, which is exactly what a well-formed ICU codeflow update should look like.

Summary: This is a mechanical, low-risk version bump with no product source, build logic, or test changes. The property version, XML dependency version, and commit SHA are internally consistent and match the PR's build/commit metadata. There are no actionable findings. Correctness is ultimately gated by the branch's CI validation of the new ICU build; assuming CI is green, this LGTM.

Detailed Findings

No issues found. The diff is limited to a consistent, auto-generated ICU transport dependency version/SHA update across eng/Version.Details.props and eng/Version.Details.xml.

Note

This review was generated by this repository's Holistic Review agentic workflow to complement the built-in Copilot review.

Generated by Holistic Review · 29.6 AIC · ⌖ 10.3 AIC · ⊞ 10K

@mrek-msft

Copy link
Copy Markdown
Member

/ba-g only two failures on WASM without any easily observable test failure, stack trace or whatever. Seems more like transient infra issue.

@mrek-msft mrek-msft added the Servicing-approved Approved for servicing release label Jul 21, 2026
@mrek-msft
mrek-msft merged commit 551825f into release/10.0 Jul 21, 2026
166 of 169 checks passed
@mrek-msft
mrek-msft deleted the darc-release/10.0-4d24a1a3-63ec-46ab-926d-7999a668cb36 branch July 21, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-codeflow for labeling automated codeflow Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants