Follow-ups to GVM dispatch change#130753
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes small NativeAOT follow-up fixes around interface dispatch resolution by (1) explicitly naming the classlib callback ID used for dispatch resolution and (2) making the dispatch-resolve assembly’s internal control-flow labels unambiguous within the INTERFACE_DISPATCH macro expansions.
Changes:
- Define
ClasslibFunctionId::ResolveDispatch = 4inICodeManager.h(instead of leaving slot 4 unnamed/“unused”). - Replace numeric local labels (
1f,2b, etc.) withLOCAL_LABEL(...\@)labels in the arm64/amd64DispatchResolve.Simplementations to ensure per-macro-expansion label uniqueness/readability.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/nativeaot/Runtime/ICodeManager.h | Names the classlib function slot 4 as ResolveDispatch to match the managed-side ID usage. |
| src/coreclr/nativeaot/Runtime/arm64/DispatchResolve.S | Refactors internal branches to use LOCAL_LABEL(...\@) labels within INTERFACE_DISPATCH. |
| src/coreclr/nativeaot/Runtime/amd64/DispatchResolve.S | Same label refactor as arm64, using LOCAL_LABEL(...\@) for macro-local label names. |
jkotas
approved these changes
Jul 15, 2026
sbomer
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.