[mono] Fix interface call in case of reabstraction - #131219
Merged
Merged
Conversation
An interface is assigned an offset in the vtable of a class that implements it, so that a call through a method on that interface will do a call through the vtable slot. There are multiple places where this offset computation happens, for example `mono_class_setup_count_virtual_methods`. Method reabstraction doesn't create a new slot. Interface calls are dispatched through imt slots that are placed before the vtable. A slot is initialized in `build_imt_slots` so that it calls through the corresponding vtable slot. For slots where we have collision of multiple interface methods, we emit some thunk that does repeated checks to dispatch to the right method. The `build_imt_slots` method didn't handle reabstraction so the vtable slot to be called for an interface method was incorrectly computed. This would appear to suggest that all cases of interface method reabstraction are broken. However, it wasn't the case because even though we incorrectly initialize the imt_slot with the wrong implementing method, `mini_resolve_imt_method` will end up patching the imt_slot if we don't have collisions, over-writting with the correct target. Added a testcase with multiple reabstracted methods on a type.
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @steveisok, @vitek-karas |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Mono’s IMT slot construction to ignore reabstracted interface methods when computing the vtable slot to call, preventing incorrect interface dispatch for IMT slots that require collision trampolines. It also adds a regression test that defines an interface with many reabstracted members to validate dispatch stability.
Changes:
- Skip reabstracted interface methods in
build_imt_slots(both the generic-interface fast path and the normal path) so they don’t affectvt_slotaccounting or IMT entry construction. - Add a new regression test project and test case exercising interface dispatch in the presence of many reabstracted members.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/mono/mono/metadata/object.c | Skips reabstracted methods while building IMT entries so vtable slot selection remains correct, especially for collision trampolines. |
| src/tests/Loader/classloader/DefaultInterfaceMethods/regressions/ReabstractedInterfaceMethodIMT.cs | Adds a regression test that invokes many interface methods on a type whose interface includes many reabstracted members. |
| src/tests/Loader/classloader/DefaultInterfaceMethods/regressions/ReabstractedInterfaceMethodIMT.csproj | Adds the test project file for building/running the new regression test. |
This was referenced Jul 22, 2026
lateralusX
approved these changes
Jul 27, 2026
lateralusX
left a comment
lateralusX
left a comment
Member
There was a problem hiding this comment.
LGTM! nit: maybe add a generic version of the test to hit the generic path as well?
BrzVlad
force-pushed
the
fix-mono-dim-reabstraction
branch
from
July 27, 2026 15:54
1c2977a to
8e751a7
Compare
Member
Author
|
/ba-g unrelated wasm |
Member
Author
|
/backport to release/10.0 |
Contributor
|
Started backporting to |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An interface is assigned an offset in the vtable of a class that implements it, so that a call through a method on that interface will do a call through the vtable slot. There are multiple places where this offset computation happens, for example
mono_class_setup_count_virtual_methods. Method reabstraction doesn't create a new slot.Interface calls are dispatched through imt slots that are placed before the vtable. A slot is initialized in
build_imt_slotsso that it calls through the corresponding vtable slot. For slots where we have collision of multiple interface methods, we emit some thunk that does repeated checks to dispatch to the right method. Thebuild_imt_slotsmethod didn't handle reabstraction so the vtable slot to be called for an interface method was incorrectly computed. This would appear to suggest that all cases of interface method reabstraction are broken. However, it wasn't the case because even though we incorrectly initialize the imt_slot with the wrong implementing method,mini_resolve_imt_methodwill end up patching the imt_slot if we don't have collisions, over-writting with the correct target.Added a testcase with multiple reabstracted methods on a type.
Fixes #129496