Seed doc comments for WASM PackedSimd intrinsics#131322
Merged
tannergooding merged 2 commits intoJul 24, 2026
Merged
Conversation
Port the remaining System.Runtime.Intrinsics.Wasm.PackedSimd summaries to match the established Arm/x86 format: the C intrinsic prototype followed by the WASM instruction with its immediate operands and stack transition. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
vcsjones
reviewed
Jul 24, 2026
vcsjones
reviewed
Jul 24, 2026
vcsjones
reviewed
Jul 24, 2026
vcsjones
reviewed
Jul 24, 2026
The unsigned i64x2 relative comparisons have no direct WASM instruction and are lowered as a signed comparison over sign-bit-flipped operands. Document the instruction that actually executes plus a caveat, matching how the Arm and x86 docs handle synthetic APIs, rather than naming an instruction that does not exist. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
vcsjones
approved these changes
Jul 24, 2026
tannergooding
enabled auto-merge (squash)
July 24, 2026 19:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeds the documentation port for
System.Runtime.Intrinsics.Wasm.PackedSimd, the last remaining intrinsics class with undocumented members tracked by #88574. All other Vector/Arm/x86 APIs from the .NET 8.0 batch are already ported; the Wasm APIs were flagged as advanced and shipped without docs.Each member summary now follows the same shape as the ported Arm/x86 docs -- the C intrinsic prototype on the first
<para>, and the WASM instruction on the second:The C prototypes come from
wasm_simd128.h. The instruction line matches the WebAssembly SIMD spec: the mnemonic, its immediate operands (laneidx,memarg), and the stack transition. The three unsignedi64x2comparisons (lt_u/le_u/gt_u) have no correspondingwasm_*intrinsic, so they carry only the instruction line.This seeds the runtime-side
///comments; the dotnet-api-docs XML is generated from these via the mddocs flow.Note
This PR description and the doc-comment text were drafted with GitHub Copilot.