Skip to content

Implement CLR data Request methods in cDAC#131335

Merged
rcj1 merged 3 commits into
mainfrom
copilot/clrdatatask-request-on-cdac
Jul 24, 2026
Merged

Implement CLR data Request methods in cDAC#131335
rcj1 merged 3 commits into
mainfrom
copilot/clrdatatask-request-on-cdac

Conversation

Copilot AI commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Implements CLRDATA_REQUEST_REVISION for ClrDataTask, ClrDataMethodDefinition, ClrDataMethodInstance, and ClrDataValue.

Changes

  • Match native DAC revision values and argument validation.
  • Translate invalid arguments and null output buffers to their corresponding HRESULTs.
  • Cross-validate HRESULTs and revision values against the legacy DAC in debug builds.
  • Cover successful requests and invalid buffer scenarios with unit tests.

Note

This pull request was generated with GitHub Copilot.

Copilot AI and others added 3 commits July 24, 2026 17:26
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 24, 2026 17:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 4 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@rcj1
rcj1 marked this pull request as ready for review July 24, 2026 17:56
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 4 pipeline(s).
12 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

@rcj1
rcj1 enabled auto-merge (squash) July 24, 2026 20:35
@rcj1
rcj1 merged commit fe8656c into main Jul 24, 2026
83 checks passed
@rcj1
rcj1 deleted the copilot/clrdatatask-request-on-cdac branch July 24, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants