Implement CLRDataMethodInstance APIs in cDAC by Copilot · Pull Request #131340 · dotnet/runtime

Copilot · 2026-07-24T18:18:43Z

Implements CLRDataMethodInstance.GetDefinition and GetAddressRangesByILOffset using cDAC contracts.

Changes

Method definitions
- Resolves the defining module and metadata token from the MethodDesc.
- Preserves legacy child-object fallback and debug HRESULT validation.
IL address ranges
- Produces native ranges from debug-info IL mappings.
- Matches native DAC buffer, epilog, and E_NOINTERFACE semantics.
- Cross-validates results against the legacy DAC in debug builds.
Coverage
- Adds dump tests for metadata resolution, matching address ranges, and missing IL offsets.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

azure-pipelines · 2026-07-24T18:19:33Z

Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

azure-pipelines · 2026-07-26T01:09:46Z

Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

dotnet-policy-service · 2026-07-26T01:09:57Z

Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot

Copilot's findings

Comments suppressed due to low confidence (1)

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataMethodInstance.cs:475

GetILAddressMap can throw before writing mapNeeded (e.g., when there’s no debug info). Even though this PR now throws InvalidCastException for the empty-map case, mapNeeded should still be set to 0 on all failure paths to avoid leaving an uninitialized out parameter.

            if (map.Count == 0)
                throw new InvalidCastException();

Files reviewed: 3/3 changed files
Comments generated: 5

    CLRDATA_SOURCE_TYPE_INVALID = 0,
 }

+public enum CLRDataILOffsetMarker : uint


+                if (addressRanges is not null && hits < addressRanges.Length)
+                {
+                    uint nativeEndOffset = i == map.Count - 1 ? 0 : map[i + 1].NativeOffset;
+                    addressRanges[hits].startAddress = new TargetPointer(codeStart + entry.NativeOffset).ToClrDataAddress(_target);
+                    addressRanges[hits].endAddress = entry.ILOffset == (uint)CLRDataILOffsetMarker.CLRDATA_IL_OFFSET_EPILOG && nativeEndOffset == 0
+                        ? default
+                        : new TargetPointer(codeStart + nativeEndOffset).ToClrDataAddress(_target);
+                }


Copilot

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Comments suppressed due to low confidence (1)

src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/IXCLRData.cs:552

Adding a new public enum here expands the surface area of the (packable) Legacy assembly, but the PR description doesn’t link an api-approved issue. If these marker values are only an implementation detail for interpreting ilOffset values, make the enum internal (or replace with private const uint values) to avoid introducing a new public API type.

public enum CLRDataILOffsetMarker : uint

Files reviewed: 3/3 changed files
Comments generated: 2

    int GetAddressRangesByILOffset(
        uint ilOffset,
        uint rangesLen,
        uint* rangesNeeded,
-        /*CLRDATA_ADDRESS_RANGE* */ void* addressRanges);
+        [In, Out, MarshalUsing(CountElementName = nameof(rangesLen))] ClrDataAddressRange[]? addressRanges);


+        IXCLRDataMethodDefinition methodDefinition = Assert.IsAssignableFrom<IXCLRDataMethodDefinition>(definitionOut.Interface);
+        DacComNullableByRef<IXCLRDataModule> nullModule = new(isNullRef: true);
+        uint instanceToken;
+        hr = methodInstance.GetTokenAndScope(&instanceToken, nullModule);
+        AssertHResult(HResults.S_OK, hr);
+
+        uint definitionToken;
+        hr = methodDefinition.GetTokenAndScope(&definitionToken, nullModule);
+        AssertHResult(HResults.S_OK, hr);
+        Assert.Equal(instanceToken, definitionToken);


noahfalk · 2026-07-27T22:32:51Z

+
+        try
+        {
+            if (canFallback && _legacyImpl is not null)


If we can't fallback shouldn't we return E_NOTIMPL? Right now it looks like we return a ClrMethodDefinition that has a NULL legacyMethodDefinition embedded inside it or maybe that constructor throws some other error.

Copilot AI and others added 4 commits July 24, 2026 17:56

Implement cDAC method instance APIs

f9765e1

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Test cDAC method instance APIs

be7f470

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Strengthen cDAC definition test

6c54a9e

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Name cDAC epilog offset sentinel

8cff41f

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot AI self-assigned this Jul 24, 2026

Copilot AI review requested due to automatic review settings July 24, 2026 18:18

Copilot AI assigned rcj1 Jul 24, 2026

Copilot AI reviewed Jul 24, 2026

Copilot created this pull request from a session on behalf of rcj1 July 24, 2026 18:19 View session

Copilot finished work on behalf of rcj1 July 24, 2026 18:19

Copilot AI requested a review from rcj1 July 24, 2026 18:19

github-actions Bot added the area-Diagnostics-coreclr label Jul 24, 2026

Copilot started work on behalf of rcj1 July 24, 2026 19:12 View session

Use IXCLRData IL offset marker enum

668c2a2

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 24, 2026 19:40

Copilot AI reviewed Jul 24, 2026

Copilot finished work on behalf of rcj1 July 24, 2026 19:46

Copilot started work on behalf of rcj1 July 24, 2026 23:15 View session

Marshal cDAC address range buffers

80a0c9e

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 24, 2026 23:35

Copilot AI reviewed Jul 24, 2026

Validate address range array marshalling

76648a7

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 24, 2026 23:42

Copilot AI reviewed Jul 24, 2026

Copilot finished work on behalf of rcj1 July 24, 2026 23:43

This was referenced Jul 25, 2026

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

Copilot started work on behalf of rcj1 July 26, 2026 00:01 View session

Gate legacy fallback usage behind CanFallback

f8e19a6

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Restore focused cDAC fallback changes

cb300f1

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 26, 2026 01:05

Copilot AI reviewed Jul 26, 2026

Update Entrypoints.cs

70ab819

Copilot AI review requested due to automatic review settings July 26, 2026 01:08

Copilot started reviewing on behalf of rcj1 July 26, 2026 01:08 View session

rcj1 added area-Diagnostics-cdac and removed area-Diagnostics-coreclr labels Jul 26, 2026

rcj1 requested review from hoyosjs, max-charlamb and noahfalk July 26, 2026 01:09

rcj1 marked this pull request as ready for review July 26, 2026 01:09

rcj1 and others added 4 commits July 25, 2026 18:11

Delete test_marshal.cs

7883ca8

Delete TestProj/Program2.cs

572cb58

Restore focused cDAC fallback changes

2565ff8

Co-authored-by: rcj1 <77995559+rcj1@users.noreply.github.com>

Delete TestProj/Program.cs

47c5d30

Copilot finished work on behalf of rcj1 July 26, 2026 01:12

rcj1 added 3 commits July 25, 2026 18:13

Delete test_hresult.cs

818cc6c

Delete TestProj/TestProj.csproj

d53c605

Delete test.cs

54ca713

Copilot AI reviewed Jul 26, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 26, 2026 01:14

Copilot AI reviewed Jul 26, 2026

Potential fix for pull request finding

9510795

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings July 26, 2026 01:28

Copilot started reviewing on behalf of rcj1 July 26, 2026 01:28 View session

Copilot AI reviewed Jul 26, 2026

View reviewed changes

noahfalk reviewed Jul 27, 2026

View reviewed changes

Uh oh!

Conversation

Copilot AI commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines Bot commented Jul 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

azure-pipelines Bot commented Jul 26, 2026

Uh oh!

dotnet-policy-service Bot commented Jul 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

noahfalk Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jul 24, 2026 •

edited

Loading