Remove host_mode_t::split_fx#131348
Merged
Merged
Conversation
Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>
Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
elinor-fung
July 24, 2026 20:44
View session
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
elinor-fung
changed the title
host_mode_t::split_fx
elinor-fung
reviewed
Jul 24, 2026
Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>
elinor-fung
reviewed
Jul 24, 2026
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
jkoritzinsky
approved these changes
Jul 24, 2026
hez2010
pushed a commit
to hez2010/runtime
that referenced
this pull request
Jul 26, 2026
The `host_mode_t::split_fx` kicked in when coreclr was next to the .NET root, there's no <app>.deps.json in the root, and there is an <app>.runtimeconfig.json in the current working directory. This was for 1.x scenarios that have not existed for many years and can actually cause confusing or incorrect behaviour now (dotnet#12933 (comment), dotnet#64517). Fixes dotnet#64517 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com> Co-authored-by: Elinor Fung <elfung@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
host_mode_t::split_fxkicked in when coreclr was next to the .NET root, there's no .deps.json in the root, and there is an .runtimeconfig.json in the current working directory. This was for 1.x scenarios that have not existed for many years and can actually cause confusing or incorrect behaviour now (#12933 (comment), #64517).Fixes #64517
cc @dotnet/appmodel @AaronRobinsonMSFT