Skip to content

Remove PEAssembly::UrlToPath and PEAssembly::FindLastPathSeparator - #131359

Merged
elinor-fung merged 1 commit into
mainfrom
copilot/remove-peassembly-urltopath
Jul 27, 2026
Merged

Remove PEAssembly::UrlToPath and PEAssembly::FindLastPathSeparator#131359
elinor-fung merged 1 commit into
mainfrom
copilot/remove-peassembly-urltopath

Conversation

Copilot AI commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Remove two dead/thin static helpers from PEAssembly:

  • UrlToPath — no callers; deleted outright.
  • FindLastPathSeparator — was a one-liner wrapping SString::FindBack; inlined at its two call sites in nativeimage.cpp and nativelibrary.cpp.

cc @dotnet/appmodel @AaronRobinsonMSFT

Co-authored-by: elinor-fung <47805090+elinor-fung@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

@elinor-fung
elinor-fung marked this pull request as ready for review July 25, 2026 01:19
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

1 similar comment
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

@elinor-fung
elinor-fung merged commit 51c924d into main Jul 27, 2026
113 checks passed
@github-project-automation github-project-automation Bot moved this to Done in AppModel Jul 27, 2026
@elinor-fung
elinor-fung deleted the copilot/remove-peassembly-urltopath branch July 27, 2026 16:48
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-rc1 milestone Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants