Normalize TYP_BYREF to TYP_INT in implicit casts even on x86 - #131442
Draft
adamperlin wants to merge 1 commit into
Draft
Normalize TYP_BYREF to TYP_INT in implicit casts even on x86#131442adamperlin wants to merge 1 commit into
adamperlin wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
area-CodeGen-coreclr
|
Azure Pipelines: Successfully started running 5 pipeline(s). 11 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts impImplicitIorI4Cast in the JIT importer so the “pointer-like (ref/byref) -> int” normalization path is no longer accidentally gated to TARGET_64BIT, enabling the same implicit-cast normalization behavior on x86 as well.
Changes:
- Move the
#endif // TARGET_64BITso the(wantedType == TYP_INT) && varTypeIsI(currType)cast-to-TYP_INTpath is compiled on all targets. - Preserve the existing 64-bit-only behavior for casting
TYP_INTtoTYP_I_IMPLwhenTYP_I_IMPL != TYP_INT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.