Fix missed case of COOP to PREEMPT transition - #131444
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli |
Member
Author
|
/azp list |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the CoreCLR interpreter’s delegate-invoke slow path to ensure the COOP→PREEMPT transition happens before calling APIs that may require preemptive mode (notably via GetMultiCallableAddrOfCode → MethodDesc::GetTemporaryEntryPoint).
Changes:
- Introduces
InvokeDelegateInvokeMethodHelperto wrapGetMultiCallableAddrOfCode(...)+ stub update underGCX_PREEMP(). - Updates
InvokeDelegateInvokeMethodto use the helper when the cached call stub template is missing.
Member
Author
|
/azp run runtime-interpreter |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
janvorli
approved these changes
Jul 27, 2026
Member
Author
|
/ba-g This might have regressed 1 gc test, but the fundamental failure is fixed, and if the test is failing due to this fuc, it's the test that needs to be fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131435
Note
This PR description was generated with GitHub Copilot CLI.