[Tests] Disable inproc crash reporter for intentional crashing tests - #131536
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
There was a problem hiding this comment.
Pull request overview
Updates the unhandled-exception test harness to avoid emitting crash-report artifacts/log noise when the child process is expected to terminate abnormally, by explicitly clearing crash-report-related environment variables for the spawned process.
Changes:
- Update the comment to reflect disabling broader crash diagnostics (not just dump generation).
- Remove
DOTNET_EnableCrashReportfrom the child process environment in addition toDOTNET_DbgEnableMiniDump.
|
There is actually another test that needs this change: |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 13d168eb-c2c9-410e-b5fb-be2637ac4e9a
janvorli
left a comment
There was a problem hiding this comment.
LGTM, thank you for fixing it.
The test intentionally expects an unhandled exception to occur. The helix test wrapper enables crash reporting in
runtime/eng/testing/RunnerTemplate.sh
Lines 118 to 119 in d75c1ca
DOTNET_DbgEnableMiniDumpto disable the only crash reporter at the time, createdump.With the in-proc crashreporter supported on macOS and Linux, there are now two crash reporting mechanisms, with the in-proc crash reporter being enabled should
DOTNET_EnableCrashReport/DOTNET_EnableCrashReportOnlybe set whileDOTNET_DbgEnableMiniDumpis unset. As a result, this test unintentionally began crash reporting after inducing unhandled exception scenarios.Originally
InProc CrashReporter enabled
This PR cleans the test output by removing DOTNET_EnableCrashReport, thereby disabling the inproc crash reporter.
It applies the same changes for similarly crash-expecting tests