Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1080,6 +1080,23 @@ internal class ClassWithAbstractProp
public AbstractBase AbstractProp { get; set; }
}

internal class ClassWithGetterOnlyProperties
{
public ClassWithGetterOnlyProperties(bool initializeProperties)
{
if (initializeProperties)
{
Nested = new();
Collection = ["existing"];
Abstract = new Derived();
}
}

public NestedOptions? Nested { get; }
public List<string>? Collection { get; }
public AbstractBase? Abstract { get; }
}

internal class ClassWithAbstractCtorParam
{
public AbstractBase AbstractProp { get; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2942,6 +2942,85 @@ public static void TestBindingUninitializedAbstractMember()
Assert.Throws<InvalidOperationException>(() => configuration.Bind(c));
}

[Fact]
public static void Bind_GetterOnlyProperties_WithNonNullValues_BindsExistingInstances()
Comment thread
svick marked this conversation as resolved.
{
IConfiguration configuration = TestHelpers.GetConfigurationFromJsonString(
"""
{
"Nested": { "Integer": 1 },
"Collection": [ "item" ],
"Abstract": { "Value": 2 }
}
""");
ClassWithGetterOnlyProperties instance = new(initializeProperties: true);

configuration.Bind(instance);

Assert.NotNull(instance.Nested);
Assert.Equal(1, instance.Nested.Integer);
Assert.NotNull(instance.Collection);
Assert.Equal(["existing", "item"], instance.Collection);
Assert.NotNull(instance.Abstract);
Assert.Equal(2, instance.Abstract.Value);
}

[Fact]
public static void Bind_GetterOnlyProperties_WithNullValues_IgnoresConfiguration()
Comment thread
svick marked this conversation as resolved.
{
IConfiguration configuration = TestHelpers.GetConfigurationFromJsonString(
"""
{
"Nested": { "Integer": 1 },
"Collection": [ "item" ]
}
""");
ClassWithGetterOnlyProperties instance = new(initializeProperties: false);

configuration.Bind(instance);

Assert.Null(instance.Nested);
Assert.Null(instance.Collection);
}

[Fact]
public static void Bind_GetterOnlyProperties_WithMissingConfiguration_LeavesExistingInstancesUnchanged()
{
IConfiguration configuration = TestHelpers.GetConfigurationFromJsonString("{}");
ClassWithGetterOnlyProperties instance = new(initializeProperties: true);
Assert.NotNull(instance.Nested);
Assert.NotNull(instance.Collection);
Assert.NotNull(instance.Abstract);
NestedOptions nested = instance.Nested;
List<string> collection = instance.Collection;
AbstractBase abstractInstance = instance.Abstract;

configuration.Bind(instance);

Assert.Same(nested, instance.Nested);
Assert.Equal(0, nested.Integer);
Assert.Same(collection, instance.Collection);
Assert.Equal(["existing"], collection);
Assert.Same(abstractInstance, instance.Abstract);
Assert.Equal(0, abstractInstance.Value);
}

[Fact]
public static void Bind_GetterOnlyAbstractProperty_WithNullValue_IgnoresConfiguration()
{
IConfiguration configuration = TestHelpers.GetConfigurationFromJsonString(
"""
{
"Abstract": { "Value": 2 }
}
""");
ClassWithGetterOnlyProperties instance = new(initializeProperties: false);

configuration.Bind(instance);

Assert.Null(instance.Abstract);
Comment thread
svick marked this conversation as resolved.
}

[Fact]
public void GetIConfigurationSection()
{
Expand Down
Loading