Configure Server GC for NativeAOT regression test - #131727
Merged
jkotas merged 1 commit intoAug 3, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @anicka-net, @dotnet/gc |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GC regression test project configuration so the test can reliably run with Server GC when executed under NativeAOT, where the GC flavor is selected at link time rather than via runtime environment variables.
Changes:
- Set
ServerGarbageCollectiontotruein the test’s.csprojso NativeAOT links the Server GC runtime. - Add an explanatory comment clarifying why the property is needed for NativeAOT.
Member
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This was referenced Aug 3, 2026
jkotas
approved these changes
Aug 3, 2026
jkotas
left a comment
jkotas
left a comment
Member
There was a problem hiding this comment.
LGTM once the test is confirmed to pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131669.
PR #131069 added a Server GC regression test, but NativeAOT selects the GC implementation at link time. Set
ServerGarbageCollectionso the test runs correctly in NativeAOT outerloop.Note
This pull request was created with GitHub Copilot assistance.