Zip centraldirectory Hardening - #131738
Draft
alinpahontu2912 wants to merge 2 commits into
Draft
Conversation
…ontu2912/zip-centraldir-hardening
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/area-system-io-compression |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens validation when parsing central directory file headers by short-circuiting reads when the header’s variable-length tail (filename/extra/comment) claims more bytes than remain in a seekable stream, avoiding an unnecessary large ArrayPool rent in that malformed-input case.
Changes:
- Add a seekable-stream “remaining bytes” check before renting/collating the dynamic header buffer in
ZipCentralDirectoryFileHeader.TryReadBlock. - Return
falseearly when the central directory header’s trailing data length exceeds what’s left in the stream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add extra check to protect against malformed central directory metadata