Skip to content

Fix IsSupported unit test for Android's X25519 implementation - #131751

Merged
vcsjones merged 1 commit into
dotnet:mainfrom
vcsjones:x25519-android-issupported-fix
Aug 4, 2026
Merged

Fix IsSupported unit test for Android's X25519 implementation#131751
vcsjones merged 1 commit into
dotnet:mainfrom
vcsjones:x25519-android-issupported-fix

Conversation

@vcsjones

@vcsjones vcsjones commented Aug 3, 2026

Copy link
Copy Markdown
Member

Fixes #131633

@vcsjones vcsjones self-assigned this Aug 3, 2026
Copilot AI review requested due to automatic review settings August 3, 2026 14:40
@vcsjones vcsjones added area-System.Security test-bug Problem in test source code (most likely) labels Aug 3, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the X25519 IsSupported_AgreesWithPlatform unit test to avoid asserting a fixed support expectation on Android API levels < 33, where Conscrypt may provide XDH support via out-of-band updates even when the documented platform floor says otherwise.

Changes:

  • Adds an early-return guard for Android < API 33 so either true or false is treated as acceptable on those OS versions.
  • Keeps the existing expectation that Android API 33+ should report support.
Show a summary per file
File Description
src/libraries/Common/tests/System/Security/Cryptography/X25519DiffieHellmanImplementationTests.cs Skips the strict platform agreement assertion on Android versions earlier than API 33 to prevent false failures.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@vcsjones
vcsjones merged commit aa71fa3 into dotnet:main Aug 4, 2026
100 of 102 checks passed
@vcsjones
vcsjones deleted the x25519-android-issupported-fix branch August 4, 2026 00:07
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-rc1 milestone Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Security test-bug Problem in test source code (most likely)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure: System.Security.Cryptography.Tests.X25519DiffieHellmanImplementationSupportedTests.IsSupported_AgreesWithPlatform

3 participants