Fix IsSupported unit test for Android's X25519 implementation - #131751
Merged
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the X25519 IsSupported_AgreesWithPlatform unit test to avoid asserting a fixed support expectation on Android API levels < 33, where Conscrypt may provide XDH support via out-of-band updates even when the documented platform floor says otherwise.
Changes:
- Adds an early-return guard for Android < API 33 so either
trueorfalseis treated as acceptable on those OS versions. - Keeps the existing expectation that Android API 33+ should report support.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/Common/tests/System/Security/Cryptography/X25519DiffieHellmanImplementationTests.cs | Skips the strict platform agreement assertion on Android versions earlier than API 33 to prevent false failures. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
PranavSenthilnathan
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131633