Open
Disable GetGeneration test under interpreter (InterpreterIncompatible)#131816
Conversation
|
Azure Pipelines: 16 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: BrzVlad <4720621+BrzVlad@users.noreply.github.com>
BrzVlad
approved these changes
Aug 4, 2026
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/tests/GC/API/GC/GetGeneration.csproj:5
- Project-level
InterpreterIncompatiblecauses the entire test assembly to exit early via the generated run script, which means Helix/test reporting treats this as “not executed” rather than an explicit xUnit skip. For this test (which already uses xUnit +SkipOnCoreClr), it’s more consistent and discoverable to add a[SkipOnCoreClr(..., RuntimeTestModes.InterpreterActive)]attribute onTestEntryPoint(similar tosrc/tests/GC/API/GC/Collect.cs) so the skip shows up in test results with a reason, instead of suppressing execution at the harness layer.
<!-- Interpreter reports locals as pinned, causing generation demotion that this test does not expect -->
<InterpreterIncompatible>true</InterpreterIncompatible>
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli |
davidwrighton
approved these changes
Aug 4, 2026
janvorli
approved these changes
Aug 4, 2026
Copilot
AI
changed the title
[WIP] Fix failed test for GetGeneration in GC API
Disable GetGeneration test under interpreter (InterpreterIncompatible)
Aug 4, 2026
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GC/API/GC/GetGeneration/GetGeneration.dllfails heavily on runtime-interpreter configs: the test expects an object's generation to advance afterGC.Collect(), but the interpreter reports the local holding it as pinned, causing the GC to demote it back to generation 0.Changes
InterpreterIncompatibletotrueinGetGeneration.csprojto skip the test on interpreter configs until precise local reporting is implemented.