Skip to content

Disable GetGeneration test under interpreter (InterpreterIncompatible) - #131816

Open
BrzVlad with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-failed-getgeneration-test
Open

Disable GetGeneration test under interpreter (InterpreterIncompatible)#131816
BrzVlad with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-failed-getgeneration-test

Conversation

Copilot AI commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

GC/API/GC/GetGeneration/GetGeneration.dll fails heavily on runtime-interpreter configs: the test expects an object's generation to advance after GC.Collect(), but the interpreter reports the local holding it as pinned, causing the GC to demote it back to generation 0.

Changes

  • Set InterpreterIncompatible to true in GetGeneration.csproj to skip the test on interpreter configs until precise local reporting is implemented.

Copilot AI self-assigned this Aug 4, 2026
Copilot AI review requested due to automatic review settings August 4, 2026 16:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
16 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Co-authored-by: BrzVlad <4720621+BrzVlad@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 4, 2026 16:49
@BrzVlad
BrzVlad marked this pull request as ready for review August 4, 2026 16:52
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/tests/GC/API/GC/GetGeneration.csproj:5

  • Project-level InterpreterIncompatible causes the entire test assembly to exit early via the generated run script, which means Helix/test reporting treats this as “not executed” rather than an explicit xUnit skip. For this test (which already uses xUnit + SkipOnCoreClr), it’s more consistent and discoverable to add a [SkipOnCoreClr(..., RuntimeTestModes.InterpreterActive)] attribute on TestEntryPoint (similar to src/tests/GC/API/GC/Collect.cs) so the skip shows up in test results with a reason, instead of suppressing execution at the harness layer.
    <!-- Interpreter reports locals as pinned, causing generation demotion that this test does not expect -->
    <InterpreterIncompatible>true</InterpreterIncompatible>

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @BrzVlad, @janvorli
See info in area-owners.md if you want to be subscribed.

Copilot AI changed the title [WIP] Fix failed test for GetGeneration in GC API Disable GetGeneration test under interpreter (InterpreterIncompatible) Aug 4, 2026
Copilot AI requested a review from BrzVlad August 4, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed test: GC/API/GC/GetGeneration/GetGeneration.dll

5 participants