Disable GC/API/Refresh test when using segments GC flavor - #131967
Conversation
The test was disabled on architecture basis before for targets that don't support regions GC, but that doesn't work when testing with the clrgc.dll that is build with segments GC flavor on 64 bit architectures. Close dotnet#130828
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
jkoritzinsky
left a comment
jkoritzinsky
left a comment
There was a problem hiding this comment.
Use ConditionalFact instead of auto-passing so it's correctly marked as "skipped"?
|
@jkoritzinsky thank you, I've moved to that way and also fixed the check that was actually incorrect. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (2)
src/tests/GC/API/Refresh/Refresh.cs:28
- If you rename the condition to
UsesGCWithRegions(to keep theGCinitialism capitalized), update the[ConditionalFact]to reference the new member name as well.
[ConditionalFact(typeof(Program), nameof(UsesGcWithRegions))]
src/tests/GC/API/Refresh/Refresh.cs:11
- Identifier uses mixed-case initialism (
UsesGcWithRegions). In this repo, initialisms like GC are consistently all-caps (e.g.,IsGCStress), so this should beUsesGCWithRegionsfor consistency and readability.
This issue also appears on line 28 of the same file.
public static bool UsesGcWithRegions
The test was disabled on architecture basis before for targets that don't support regions GC, but that doesn't work when testing with the clrgc.dll that is build with segments GC flavor on 64 bit architectures.
Close #130828