Skip to content

Fix Turkish casing on Android by deriving it from the locale name #132001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MsfPablo wants to merge 1 commit into from
+14 −1
Closed

Fix Turkish casing on Android by deriving it from the locale name #132001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/libraries/System.Private.CoreLib/src/System/Globalization/TextInfo.Icu.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,20 @@ private static bool NeedsTurkishCasing(string localeName)
{
Debug.Assert(localeName != null);

return CultureInfo.GetCultureInfo(localeName).CompareInfo.Compare("\u0131", "I", CompareOptions.IgnoreCase) == 0;
// ICU applies the Turkish dotted/dotless "i" casing rules to the "tr" and "az"
// languages. This is determined from the locale name rather than by probing the
// collation tailoring, because some platforms (notably Android, which uses the
// system ICU) do not ship the collation data that probe relies on, which would
// silently fall back to non-Turkish casing.
ReadOnlySpan<char> language = localeName.AsSpan();
int separatorIndex = language.IndexOfAny('-', '_');
if (separatorIndex >= 0)
{
language = language.Slice(0, separatorIndex);
}

return language.Equals("tr", StringComparison.OrdinalIgnoreCase) ||
language.Equals("az", StringComparison.OrdinalIgnoreCase);
}

internal unsafe void IcuChangeCase(char* src, int srcLen, char* dstBuffer, int dstBufferCapacity, bool bToUpper)
Expand Down
Loading