Skip to content

Determine Turkish casing from the locale name instead of collation - #132002

Open
MsfPablo wants to merge 2 commits into
dotnet:mainfrom
MsfPablo:turkish-casing-106560
Open

Determine Turkish casing from the locale name instead of collation#132002
MsfPablo wants to merge 2 commits into
dotnet:mainfrom
MsfPablo:turkish-casing-106560

Conversation

@MsfPablo

@MsfPablo MsfPablo commented Aug 7, 2026

Copy link
Copy Markdown

Fixes #106560

Problem

On Android, "i".ToUpper(new CultureInfo("tr-TR")) returns I (U+0049) instead of İ (U+0130), and "I".ToLower(...) returns i instead of ı. The same code is correct on Windows/Linux/macOS.

Cause

TextInfo.NeedsTurkishCasing does not look at the locale at all — it infers the need for Turkish casing by probing the collation tailoring:

return CultureInfo.GetCultureInfo(localeName).CompareInfo.Compare("ı", "I", CompareOptions.IgnoreCase) == 0;

Android uses the system ICU, which does not carry the tr/az collation tailoring that makes U+0131 compare equal to I under IgnoreCase (the same underlying gap tracked by #60568). The probe therefore returns false for tr-TR, IcuChangeCase takes the ChangeCase path instead of ChangeCaseTurkish, and the dotted/dotless i mapping is silently lost. GlobalizationNative_ChangeCaseTurkish itself is fine and is already built for Android — it is simply never called.

Fix

Decide from the locale's language subtag instead, which is what ICU itself does (ustrcase_getCaseLocale selects UCASE_LOC_TURKISH for languages tr and az). This removes the dependency on collation data and makes the behavior identical on every ICU platform.

This should be behavior-preserving elsewhere: tr and az are exactly the languages whose collation tailoring made the old probe return true, and the root collation does not equate U+0131 with I. The existing en-US-POSIX regression case — which exists precisely because the old check was collation-based — still passes, since its language subtag is en.

Tests

The Turkish ToUpper/ToLower cases in TextInfoTests were skipped on Android/LinuxBionic with the comment "Android has its own ICU, which doesn't work well with tr". Those guards are removed so the cases now run on those platforms and cover this fix. They exercise tr, tr-TR, az and az-Latn-AZ.

Verification

I want to be upfront: I have not built or run this locally. Building dotnet/runtime for Android and running the globalization suite on a device/emulator was not something I could do in my environment, so I am relying on CI (including the Android legs) to validate it. The change is small and self-contained, and the re-enabled test cases are the intended proof. Happy to iterate if CI shows anything unexpected — in particular if some locale I have not considered relied on the old collation-derived answer.

cc @matouskozak @tarekgh @ilonatommy

Pablo Garcia added 2 commits August 7, 2026 15:36
TextInfo.NeedsTurkishCasing detected the Turkish dotted/dotless i casing
rules by probing whether the culture collates U+0131 equal to 'I' under
IgnoreCase. On Android the system ICU does not provide the collation data
that probe depends on, so the check returned false for tr-TR and casing
silently fell back to the non-Turkish path, making i.ToUpper() yield
'I' instead of U+0130.

Fixes dotnet#106560
These ToLower/ToUpper cases were skipped on Android and LinuxBionic
because the collation-based Turkish detection did not work there. The
casing path no longer depends on collation data, so they can run.
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Aug 7, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to 'arch-android': @vitek-karas, @simonrozsival, @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

@tarekgh tarekgh added this to the 11.0.0 milestone Aug 7, 2026
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

@MsfPablo please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ),
and conveys certain license rights to the .NET Foundation ( “.NET Foundation” ) for Your contributions to
.NET Foundation open source projects. This Agreement is effective as of the latest signature date below.

1. Definitions.

“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to .NET Foundation under this Agreement.

“Project” means any of the projects owned or managed by .NET Foundation and offered under a license
approved by the Open Source Initiative (www.opensource.org).

“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”

“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.

2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.

3. Originality of Work. You represent that each of Your Submissions is entirely Your
original work. Should You wish to Submit materials that are not Your original work,
You may Submit them separately to the Project if You (a) retain all copyright and
license information that was in the materials as you received them, (b) in the
description accompanying your Submission, include the phrase "Submission
containing materials of a third party:" followed by the names of the third party and any
licenses or other restrictions of which You are aware, and (c) follow any other
instructions in the Project's written guidelines concerning Submissions.

4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.

5. Licenses.

a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly
or indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable
license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform,
and distribute the Submission and such derivative works, and to sublicense any or all of the foregoing
rights to third parties.

b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or
indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license
under Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.

c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

6. Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3 ). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6 , THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.

7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or
circumstances of which You later become aware that would make Your representations in this
Agreement inaccurate in any respect.

8. Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.

9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.

10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by .NET Foundation.

.NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1.

@tarekgh

tarekgh commented Aug 7, 2026

Copy link
Copy Markdown
Member

/azp run runtime-extra-platforms

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Globalization community-contribution Indicates that the PR has been added by a community member os-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android - With set Turkish locale "i".ToUpper() is giving 'I" instead of 'İ'

3 participants